[#11334] - Update composer libraries
- Fixed in Code Base
- 13 Aug 2016
- Medium
- Build: staging
- # 11334
- Diff
- wilsonge:composer-update
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #10835 .
Summary of Changes
Updates phpmailer, joomla registry, symfony polyfill (php 5.6), symfony yaml to their latest versions
Testing Instructions
Registry is used everywhere. So navigate around and check for errors. Yaml isn't used by core. If possible test in PHP < 5.6 to test the polyfill and check emails still send for phpmailer.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | External Library Libraries |
| Labels |
Added:
?
?
|
||
The 5.6 polyfill is used to make the hash_equals function available on PHP 5.3, 5.4 and 5.5. So check logging in with passwords still works properly on those php versions
I have tested this item
OK something went wrong.
Admin is fine but front end fails to load with this in the logs
Call to a member function getDefault() on a non-object in libraries/cms/router/site.php on line 266
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11334.
Under php7 I get
Error displaying the error page: Call to a member function getActive() on null: Call to a member function getDefault() on null
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11334.
Woohoo so Joomla's been shipping sample data with invalid JSON since 2012 - we just never had error handling :P Fixed for existing data sets and dealt with the invalid JSON
The error on the homepage has gone now
I have tested this item
Tested creating users and logging in under multiple php versions 5.4, 5.5, 5.6, 7
Tested sending mail using the testmail function in global config
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11334.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11334.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
| Labels |
Added:
?
|
||
Georges-MacBook-Pro:~ george$ composer --version
Composer version 1.0.2 2016-04-21 12:30:18
Just updated to 1.2.0
About time!
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-13 17:37:36 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on e716894
Seems ok - sendtestmail still works. No errors navigating around. Not sure what polyfil is used for
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11334.