? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
28 Jul 2016

Pull Request for Issue #11256

Second attempt this time without changing the core bootstrap files

See #11256 for description and testing

3cf5a36 28 Jul 2016 avatar brianteeman beez
avatar brianteeman brianteeman - open - 28 Jul 2016
avatar brianteeman brianteeman - change - 28 Jul 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jul 2016
Category Templates (admin) Administration Templates (site) Front End
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jul 2016
Labels Added: ?
avatar hardiktailored
hardiktailored - comment - 1 Aug 2016

Title height issue resolved. Though look at the arrows, some of them have full bordered arrow.

screen shot 2016-08-01 at 04 44 58

screen shot 2016-08-01 at 04 45 02


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11332.

avatar brianteeman
brianteeman - comment - 1 Aug 2016

I have seen that myself but ONLY when using the browser zoom to check the
css. It didnt happen when the browser ws not zoomed

On 1 August 2016 at 10:49, Hardiksinh Gohil @ Tailored <
notifications@github.com> wrote:

Title height issue resolved. Though look at the arrows, some of them have
full bordered arrow.

[image: screen shot 2016-08-01 at 04 44 58]
https://camo.githubusercontent.com/974751f0972f470a77bbe982e4ebe4db2b96f090/68747470733a2f2f6973737565732e6a6f6f6d6c612e6f72672f75706c6f6164732f312f30303339336639363363326635396438396632373761323635313039393363342e706e67

[image: screen shot 2016-08-01 at 04 45 02]

https://camo.githubusercontent.com/ca66805601e366309ed5fc41a8d3f912122a7f6d/68747470733a2f2f6973737565732e6a6f6f6d6c612e6f72672f75706c6f6164732f312f61346638346466306136656663386430333437383830623831313863666362642e706e67

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/11332
https://issues.joomla.org/tracker/joomla-cms/11332.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#11332 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8fywM4R9SW83mWsGMb_b3IhLWU5zks5qbcEigaJpZM4JXOc6
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar hardiktailored
hardiktailored - comment - 1 Aug 2016

Yes, that is one case. Same issue with responsive view. Check below mobile view. And that is not same for all.

screen shot 2016-08-01 at 05 29 56


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11332.

avatar brianteeman
brianteeman - comment - 1 Aug 2016

That works in a similar way to browser zoom. Can you replicate it on a real mobile device

avatar hardiktailored
hardiktailored - comment - 1 Aug 2016

It looks okay in real mobile device. But issue is still there when zooming in real mobile device too. But that might not be the problem. One more thing, in some of the cases title's bottom border is looks slight down to the arrow border. You can see that in first screenshot too.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11332.

avatar brianteeman
brianteeman - comment - 26 Aug 2016

@c-lodder can you test this one please


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11332.

avatar C-Lodder
C-Lodder - comment - 26 Aug 2016

Sure. Need to manually apply the PR cause the patch-tester isn't showing this PR for some reason.

avatar C-Lodder
C-Lodder - comment - 26 Aug 2016

This will only be an issue for retina devices and when zoomed in if the popover content doesn't contain more than 1 line of text.

This PR does fix it. Only thing I'd say (sorry to be nit-picky) is changing 33px to 35px

avatar brianteeman
brianteeman - comment - 26 Aug 2016

Try it with 35 and you will see why I went with 33

avatar C-Lodder C-Lodder - test_item - 26 Aug 2016 - Tested successfully
avatar C-Lodder
C-Lodder - comment - 26 Aug 2016

I have tested this item successfully on 3cf5a36

Not sure about retina desktops but is fine for me on mobile (S-Galaxy S7 Edge) with 35px. I'll take your word for it though :)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11332.

avatar brianteeman brianteeman - change - 4 Nov 2016
Easy No Yes
avatar brianteeman brianteeman - edited - 4 Nov 2016
avatar hans2103
hans2103 - comment - 4 Nov 2016

@brianteeman can you solve the conflicts of this PR please?

avatar brianteeman
brianteeman - comment - 4 Nov 2016

@hans2103 quicker to redo than resolve conflicts please double check #12749 and then it can be merged

thanks

avatar brianteeman brianteeman - change - 4 Nov 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-11-04 13:10:25
Closed_By brianteeman
avatar brianteeman brianteeman - close - 4 Nov 2016
avatar brianteeman brianteeman - close - 4 Nov 2016

Add a Comment

Login with GitHub to post a comment