[#11329] - [language filter plugin] do not cache any 301 redirect
- Fixed in Code Base
- 28 Jul 2016
- Critical
- Build: staging
- # 11329
- Diff
- andrepereiradasilva:patch-9
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
If you use latest staging in multilanguage with language filter plugin with Remove URL Language Code set to Yes, you will notice in the frontpage that switching from default language to other language and back to default language will not work properly.
When #11206 was tested with success all worked fine because this issue was masked by the duplicated code removed in #11314.
So, this PR makes so that joomla does not cache any language filter 301 redirect to avoid any browser cache issues.
Testing Instructions
- Use latest staging in multilanguage (2 languages - en-GB and fr-FR), language filter plugin enabled and with
Remove URL Language Codeset toYes. - Clear all your browser cache
- Now go to your site homepage in default language
- Click on french flag - all ok
- Now click on english flag to go back to default language - all ok
- Click on french flag again - all ok
- Now click on english flag to go back to default language - Bug! It stays in french
- Apply patch
- Repeat steps from 2. to 7. All ok now
- Code review
Note: this happens because by the second /en/ to / (step 7) the redirect is already cached in the browser so the language cookie is not changed back to en-GB.
@infograf768 @ggppdk please test
@wilsonge please check also
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Plugins Front End |
| Labels |
Added:
?
|
||
lol. i wont start that discussion again. if you think it should be 302 (instead of 301) for default language also (all non default language are already 302), make a PR for that.
i made this so 3.6.1 is not released with this bug.
I have tested this item
After cleaning cache, make sure cache is enabled in the browser!
I confirm the issue and the solution works here.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11329.
After cleaning cache, make sure cache is enabled in the browser!
yes, if you cache disabled there is no issue at all
| Priority | Medium | ⇒ | Critical |
Changing Priority as we do not want multilingial sites to be broken again...
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11329.
I'm merging this so it's in the RC i'm about to ship
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-28 22:20:13 |
| Closed_By | ⇒ | wilsonge |
Sorry to comment so late, but it seems there is an issue with 301 redirect for the default language. When hreflang annotations are used to indicate different language version, there is usually also x-default hreflang for the homepage. But if you 301 redirect homepage then it seems search engine is detecting a broken chain of hreflangs. Check answer at https://productforums.google.com/forum/?utm_medium=email&utm_source=footer#!msg/webmasters/BuLYKloslbc/I9BzIiYBBAAJ, specifically paragraph about redirection, the rest is not relevant here
Can you please open a new issue dor that? This one is merged. Thanks
Or use the uncached 302 redirects instead of a cached 301, but I'm repeating myself sigh.