? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
27 Jul 2016

Summary of Changes

The component router helper should be registered in the component association helper so when loading the helper it's already auto-loaded.
So we drop jimport and use JLoader::register

Testing Instructions

In multilanguage site, component items Associations tabs work fine (business as usual) in all core components (com_content, com_contact and com_newsfeeds) that supports associations (excluding com_menus that does not need this).

Notes

This issue was discovered in the GsoC multilingual association sproject.

Note: a similiar PR will be made for com_weblinks repository.

@infograf768 @alikon @jreys please test

avatar andrepereiradasilva andrepereiradasilva - open - 27 Jul 2016
avatar andrepereiradasilva andrepereiradasilva - change - 27 Jul 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jul 2016
Category Front End Components
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jul 2016
Labels Added: ?
avatar alikon alikon - test_item - 27 Jul 2016 - Tested successfully
avatar alikon
alikon - comment - 27 Jul 2016

I have tested this item successfully on 8b181d7


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11321.

avatar jreys jreys - test_item - 27 Jul 2016 - Tested successfully
avatar jreys
jreys - comment - 27 Jul 2016

I have tested this item successfully on 8b181d7


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11321.

avatar infograf768 infograf768 - change - 27 Jul 2016
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 27 Jul 2016

rtc.
@wilsonge can we get that in 3.6.1 ?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11321.

avatar joomla-cms-bot joomla-cms-bot - change - 27 Jul 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 27 Jul 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-07-27 18:44:31
Closed_By wilsonge
avatar wilsonge wilsonge - close - 27 Jul 2016
avatar wilsonge wilsonge - merge - 27 Jul 2016
avatar joomla-cms-bot joomla-cms-bot - close - 27 Jul 2016
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jul 2016
Labels Removed: ?
avatar ggppdk
ggppdk - comment - 27 Jul 2016

I have made same update to my extension association helper, works there too

avatar andrepereiradasilva
andrepereiradasilva - comment - 27 Jul 2016

BTW does your extension supports associations?
If so, can you post a link here: joomla-projects/gsoc16_improved-multi-lingual#29

Add a Comment

Login with GitHub to post a comment