? ?
avatar coolcat-creations
coolcat-creations
27 Jul 2016

In order to display Modules in the mod_menu it would be great to have a new Menu-Item-Type
"Module"

This issue is related to the new Frontend-Template Project issue:
Digital-Peak-Incubator/tpl_tauristar#88

avatar designbengel designbengel - open - 27 Jul 2016
avatar brianteeman
brianteeman - comment - 27 Jul 2016

Do you mean a menu item that contains a module? For example the last item on a content dropdown submenu displays the content of a module eg an image
If so then presumably this will only ever work on a submenu item and cant work on a top level?

avatar brianteeman brianteeman - change - 27 Jul 2016
Labels Added: ? ?
avatar designbengel
designbengel - comment - 27 Jul 2016

Would be great to have it working on a top level too for example a search box or language switcher. Of course it needs to be used wisely ;)

avatar brianteeman
brianteeman - comment - 27 Jul 2016

ok - I understand what you mean now.

avatar Bakual
Bakual - comment - 27 Jul 2016

Aren't there already menu module in JED which offer that possibility?

While it technically should be possible to implement this into core, it will likely fail horribly in the various templates without any modification on that part.

avatar designbengel
designbengel - comment - 27 Jul 2016

The request is in favour for the new Joomla! Frontend Template project, thats why i placed it here. (See reference in initial post)

avatar laoneo
laoneo - comment - 27 Jul 2016

I guess, mod_menu needs to be extended, to load configurable module positions. I'm not sure but I think top level is not needed as you can place already a module at the same position as mod_menu is.

avatar Bakual
Bakual - comment - 27 Jul 2016

I guess I miss what that new frontend template project tries to achieve. Afaik it's already possible to do such things with menu modules from JED so I don't see what it has to do with a specific new template.

Imho, mod_menu should be a simple menu module as it is today. if you need more extended features, take one of the many modules available on JED.
If you're going to load modules within a (menu-)module by core, you will get some tricky issues for sure further down 😄

avatar designbengel
designbengel - comment - 27 Jul 2016

But JED doesn´t help when we want to extend features for the core template. Lot of CMS offer a core "mega-menu" and i think it should be also a core feature.

avatar mbabker
mbabker - comment - 27 Jul 2016

I dunno. To me this is encroaching on adding a lot of complexity for the sake of added complexity. Ya, it might be a nice to have feature, but it's one of those edge cases where does it really belong in the core? Even if you're building a new mega menu module, what purpose does it serve to create menu items that aren't actual menu items but are instead rendering other HTML snippets? It seems like what you want is more of a core supported mega menu module with some flexibility in telling it to render other modules, but I don't think that requires updating the menu system to allow a module to be assigned as a menu item.

avatar designbengel
designbengel - comment - 27 Jul 2016

I thought it´s "just" adding a Menu item type "module" with a list of the Modulepositions. Like it was added to load a module in the article. Why not in the menu? I don´t think it´s very complex? Is it?

avatar mbabker
mbabker - comment - 27 Jul 2016

Adding new menu types actually is somewhat complex because everything is directly related to a component or is a very hardcoded exception to that rule with zero flexibility. But those exceptions still directly relate to creating items in a menu. What's being proposed here isn't the addition of new menu items, it's in essence the ability to render rich HTML snippets in the context of a menu. It's making the core menu manager a mega menu manager. No CMS I'm aware of has this capability out of the box, and IMO that's for good reason. This is exactly the type of feature that belongs in the JED; it's not a solution that is used for an overwhelming majority of websites.

I'd suggest looking at ways to make it easier to extend the menu manager to add "special types" beyond components. Because right now both the core menu component and menu modules have very hardcoded conventions that don't make it easy to add custom types. But I don't necessarily think that the core needs to support a feature out of the box to allow assigning modules as menu items.

avatar brianteeman
brianteeman - comment - 27 Jul 2016

I absolutely can see a role for something like this in the core.
I can see lots of scenarios where it will never work perfectly
I believe there are two different approaches that can be taken

  • Create a new menu type - difficult for the reasons Michael stated
  • Create a menu module that has the ability to include other modules - so it is managed in the module not the menu - this would mean a slightly more limited approach but it is achievable (i think) The latter is not really a megamenu per se but it offers some of the functionality


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11319.

avatar brianteeman brianteeman - change - 27 Jul 2016
Category Feature Request Front End
avatar Bakual
Bakual - comment - 27 Jul 2016

I'd suggest looking at ways to make it easier to extend the menu manager to add "special types" beyond components. Because right now both the core menu component and menu modules have very hardcoded conventions that don't make it easy to add custom types.

That would be the correct approach. Allow menu modules or plugins to hook into the list of "system menuitem types" and add custom ones. Then you have the flexibility to add custom types like a module menuitem (or many other yet to invent types).

avatar mbabker
mbabker - comment - 27 Jul 2016

To do what's being asked for now you have to hardcode it into the menu
system. I'm honestly not a fan of that. I don't necessarily think this
feature idea is bad for those looking for it, but I don't feel like it fits
into core as is and honestly the new module option is a bandage over a bad
wound at best. Making the menu system (component and modules) more
flexible with hooks goes a long way toward adding flexibility to the whole
platform. Basically if you do the same thing with the menus as was done in
the installer component with the tabs a little change opens a lot of
possibilities.

On Wednesday, July 27, 2016, Thomas Hunziker notifications@github.com
wrote:

I'd suggest looking at ways to make it easier to extend the menu manager
to add "special types" beyond components. Because right now both the core
menu component and menu modules have very hardcoded conventions that don't
make it easy to add custom types.

That would be the correct approach. Allow menu modules or plugins to hook
into the list of "system menuitem types" and add custom ones. Then you have
the flexibility to add custom types like a module menuitem (or many other
yet to invent types).

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11319 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfofNrpLCAcci6c2HyRruL5DcBBHxdks5qZ8YDgaJpZM4JWEEj
.

avatar brianteeman brianteeman - change - 28 Jul 2016
Status New Discussion
avatar rvbgnu
rvbgnu - comment - 3 Jun 2017

@designbengel Is this still relevant as a feature request?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11319.

avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Jun 2017
Status Discussion Information Required
avatar joomla-cms-bot joomla-cms-bot - edited - 3 Jun 2017
avatar coolcat-creations
coolcat-creations - comment - 7 Jun 2017

@rvbgnu for me: yes! :)

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Aug 2017

If this PR get no Response, it will be closed at 17th September 2017.

avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Sep 2017
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2017-09-17 06:08:21
Closed_By franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - change - 17 Sep 2017
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 17 Sep 2017
avatar joomla-cms-bot
joomla-cms-bot - comment - 17 Sep 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Sep 2017

This has been closed due to lack of response to the requests above – it can always be reopened.

Add a Comment

Login with GitHub to post a comment