?
avatar jeckodevelopment
jeckodevelopment
26 Jul 2016

Steps to reproduce the issue

In Joomla 3.6.0. if you go to "Permissions" tab for a Category, there's a wrong reference to Article instead of the Category.

Expected result

it should be " Changes apply to this category only".

Actual result

Actually is: " Changes apply to this article only."

categoryacl

Additional comments

If we have only one language string for both category and article ACL, we could change the word "article" or "category" with a generic "item".

avatar jeckodevelopment jeckodevelopment - open - 26 Jul 2016
avatar jeckodevelopment jeckodevelopment - change - 26 Jul 2016
Labels Added: ? ?
avatar jeckodevelopment jeckodevelopment - change - 26 Jul 2016
Labels Removed: ?
avatar jeckodevelopment
jeckodevelopment - comment - 26 Jul 2016

The string is correct here on GitHub: joomla-cms/administrator/language/en-GB/en-GB.com_categories.ini
But it's not up to date in the installed file, version 3.6.0

avatar zero-24
zero-24 - comment - 26 Jul 2016

@jackodevelopment can you try a staging install to be sure?

avatar brianteeman
brianteeman - comment - 26 Jul 2016

I can not confirm this on 3.6.0 or 3.6.1


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11306.

avatar jeckodevelopment
jeckodevelopment - comment - 26 Jul 2016

As said, here on Github the error doens't exist. In my installation 3.6.0 it does.
I'll try with a new staging. Thanks.

avatar brianteeman
brianteeman - comment - 26 Jul 2016

I couldnt replicate it in 3.6 either

On 26 July 2016 at 12:23, Luca Marzo notifications@github.com wrote:

As said, here on Github the error doens't exist. In my installation 3.6.0
it does.
I'll try with a new staging. Thanks.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11306 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8auKgowGbfosilJBVx9vw6jfUW7dks5qZe5GgaJpZM4JUrZ9
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman brianteeman - change - 27 Jul 2016
Category Language & Strings
avatar brianteeman brianteeman - change - 27 Jul 2016
Status New Information Required
avatar jeckodevelopment
jeckodevelopment - comment - 27 Jul 2016

I can replicate this issue on several installations of 3.6.0

avatar brianteeman
brianteeman - comment - 27 Jul 2016

What is the exact url you are on when you get that.

On 27 July 2016 at 11:46, Luca Marzo notifications@github.com wrote:

I can replicate this issue on several installations of 3.6.0


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11306 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8UgxcCSvMVmeQTsgqIXOj3kyMcSyks5qZzcfgaJpZM4JUrZ9
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar jeckodevelopment
jeckodevelopment - comment - 27 Jul 2016

administrator/index.php?option=com_categories&view=category&layout=edit&extension=com_content

avatar brianteeman
brianteeman - comment - 27 Jul 2016

Bingo - found it - thats why I asked for the exact url

I was looking at the permissions tab in the options for ALL categories not for one specific category

I will look at the code in the morning and create a PR hopefully


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11306.

avatar brianteeman brianteeman - change - 27 Jul 2016
Status Information Required Confirmed
avatar jeckodevelopment
jeckodevelopment - comment - 27 Jul 2016

Thank you Brian

avatar jeckodevelopment
jeckodevelopment - comment - 27 Jul 2016

@brianteeman
This should be the string, right?
https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/en-GB.com_content.ini#L185

JLIB_RULES_SETTING_NOTES_ITEM="Changes apply to this article only.<br /><em><strong>Inherited</strong></em> - a Global Configuration setting or higher level setting is applied.<br /><em><strong>Denied</strong></em> always wins - whatever is set at the Global or higher level and applies to all child elements.<br /><em><strong>Allowed</strong></em> will enable the action for this component unless it is overruled by a Global Configuration setting."

avatar brianteeman
brianteeman - comment - 27 Jul 2016

Not at my PC but the problem is not the content of the string the problem
is that the wrong string is being selected

avatar jeckodevelopment
jeckodevelopment - comment - 27 Jul 2016

do we need a new string for this?
I can't find the right string in the language file...

avatar brianteeman
brianteeman - comment - 27 Jul 2016

No. There is a generic string and there is alsi a category specific string.
When I get to my PC tomorrow I can fix it.

avatar brianteeman
brianteeman - comment - 28 Jul 2016

I have found the issue but I am afraid I dont know the fix

The problem is this
There is a string JLIB_RULES_SETTING_NOTES_ITEM that exists in BOTH en-GB.com_content.ini and en-GB.com_categories.ini and they are obviously different
Both the language files are being loaded on this view with content.ini loaded after categories.ini which is why we have the problem

Also I discovered that similar problem exists in another view
administrator/index.php?option=com_config&view=component&component=com_content

This time the generic value of JLIB_RULES_SETTING_NOTES_ITEM in en-GB.lib_joomla.ini is being used instead of the specific string in en-GB.com_categories.ini

avatar jeckodevelopment
jeckodevelopment - comment - 28 Jul 2016

We could fix saying "Item" instead of "Article", i guess. That's the easiest way.
Otherwise we need to have separate strings for each context.

avatar brianteeman
brianteeman - comment - 28 Jul 2016

We do - that is the problem
The correct strings are not being used. I dont know why we have the same
KEY for a string in multiple files with different values. It makes no sense
to me. I can only assume it worked correctly at some time. I am thinking it
may be something to do with a change to use a layout

On 28 July 2016 at 12:05, Luca Marzo notifications@github.com wrote:

We could fix saying "Item" instead of "Article", i guess. That's the
easiest way.
Otherwise we need to have separate strings for each context.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11306 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Xdsphzhxbjlb0M5z0dKULUK6sE1ks5qaI0VgaJpZM4JUrZ9
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar jeckodevelopment
jeckodevelopment - comment - 28 Jul 2016

And, is it possible to change the name of one string?

avatar brianteeman
brianteeman - comment - 28 Jul 2016

I think not with the way the layout is done

On 28 July 2016 at 12:48, Luca Marzo notifications@github.com wrote:

And, is it possible to change the name of one string?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11306 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8cIRGGWOWsgrHYQf7K-nObL8TvC_ks5qaJcegaJpZM4JUrZ9
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 28 Jul 2016

Doing a bandaid fix is easy. But really we need to take a deeper look at
why the strings are duplicated and why they no longer work correctly

On 28 July 2016 at 12:51, Brian Teeman brian@teeman.net wrote:

I think not with the way the layout is done

On 28 July 2016 at 12:48, Luca Marzo notifications@github.com wrote:

And, is it possible to change the name of one string?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11306 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8cIRGGWOWsgrHYQf7K-nObL8TvC_ks5qaJcegaJpZM4JUrZ9
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar jeckodevelopment
jeckodevelopment - comment - 28 Jul 2016

completely agree. I tried to look at the code yesterday, but I was lost :D

avatar brianteeman
brianteeman - comment - 3 Aug 2016

It needs to be fixed but I'm sorry I cant work out how to do it with the layouts

avatar AlexRed
AlexRed - comment - 30 Mar 2017

I can confirm in Joomla! 3.7.0-staging


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11306.

avatar brianteeman
brianteeman - comment - 29 May 2017

Closed - see
#13523

avatar brianteeman brianteeman - change - 29 May 2017
The description was changed
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2017-05-29 15:36:02
Closed_By brianteeman
avatar brianteeman brianteeman - close - 29 May 2017

Add a Comment

Login with GitHub to post a comment