In Joomla 3.6.0. if you go to "Permissions" tab for a Category, there's a wrong reference to Article instead of the Category.
it should be " Changes apply to this category only".
Actually is: " Changes apply to this article only."
If we have only one language string for both category and article ACL, we could change the word "article" or "category" with a generic "item".
Labels |
Added:
?
?
|
Labels |
Removed:
?
|
@jackodevelopment can you try a staging install to be sure?
I can not confirm this on 3.6.0 or 3.6.1
As said, here on Github the error doens't exist. In my installation 3.6.0 it does.
I'll try with a new staging. Thanks.
I couldnt replicate it in 3.6 either
On 26 July 2016 at 12:23, Luca Marzo notifications@github.com wrote:
As said, here on Github the error doens't exist. In my installation 3.6.0
it does.
I'll try with a new staging. Thanks.—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11306 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8auKgowGbfosilJBVx9vw6jfUW7dks5qZe5GgaJpZM4JUrZ9
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Category | ⇒ | Language & Strings |
Status | New | ⇒ | Information Required |
I can replicate this issue on several installations of 3.6.0
What is the exact url you are on when you get that.
On 27 July 2016 at 11:46, Luca Marzo notifications@github.com wrote:
I can replicate this issue on several installations of 3.6.0
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11306 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8UgxcCSvMVmeQTsgqIXOj3kyMcSyks5qZzcfgaJpZM4JUrZ9
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
administrator/index.php?option=com_categories&view=category&layout=edit&extension=com_content
Bingo - found it - thats why I asked for the exact url
I was looking at the permissions tab in the options for ALL categories not for one specific category
I will look at the code in the morning and create a PR hopefully
Status | Information Required | ⇒ | Confirmed |
Thank you Brian
@brianteeman
This should be the string, right?
https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/en-GB.com_content.ini#L185
JLIB_RULES_SETTING_NOTES_ITEM="Changes apply to this article only.<br /><em><strong>Inherited</strong></em> - a Global Configuration setting or higher level setting is applied.<br /><em><strong>Denied</strong></em> always wins - whatever is set at the Global or higher level and applies to all child elements.<br /><em><strong>Allowed</strong></em> will enable the action for this component unless it is overruled by a Global Configuration setting."
Not at my PC but the problem is not the content of the string the problem
is that the wrong string is being selected
do we need a new string for this?
I can't find the right string in the language file...
No. There is a generic string and there is alsi a category specific string.
When I get to my PC tomorrow I can fix it.
I have found the issue but I am afraid I dont know the fix
The problem is this
There is a string JLIB_RULES_SETTING_NOTES_ITEM that exists in BOTH en-GB.com_content.ini and en-GB.com_categories.ini and they are obviously different
Both the language files are being loaded on this view with content.ini loaded after categories.ini which is why we have the problem
Also I discovered that similar problem exists in another view
administrator/index.php?option=com_config&view=component&component=com_content
This time the generic value of JLIB_RULES_SETTING_NOTES_ITEM in en-GB.lib_joomla.ini is being used instead of the specific string in en-GB.com_categories.ini
We could fix saying "Item" instead of "Article", i guess. That's the easiest way.
Otherwise we need to have separate strings for each context.
We do - that is the problem
The correct strings are not being used. I dont know why we have the same
KEY for a string in multiple files with different values. It makes no sense
to me. I can only assume it worked correctly at some time. I am thinking it
may be something to do with a change to use a layout
On 28 July 2016 at 12:05, Luca Marzo notifications@github.com wrote:
We could fix saying "Item" instead of "Article", i guess. That's the
easiest way.
Otherwise we need to have separate strings for each context.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11306 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Xdsphzhxbjlb0M5z0dKULUK6sE1ks5qaI0VgaJpZM4JUrZ9
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
And, is it possible to change the name of one string?
I think not with the way the layout is done
On 28 July 2016 at 12:48, Luca Marzo notifications@github.com wrote:
And, is it possible to change the name of one string?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11306 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8cIRGGWOWsgrHYQf7K-nObL8TvC_ks5qaJcegaJpZM4JUrZ9
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Doing a bandaid fix is easy. But really we need to take a deeper look at
why the strings are duplicated and why they no longer work correctly
On 28 July 2016 at 12:51, Brian Teeman brian@teeman.net wrote:
I think not with the way the layout is done
On 28 July 2016 at 12:48, Luca Marzo notifications@github.com wrote:
And, is it possible to change the name of one string?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11306 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8cIRGGWOWsgrHYQf7K-nObL8TvC_ks5qaJcegaJpZM4JUrZ9
.Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
completely agree. I tried to look at the code yesterday, but I was lost :D
It needs to be fixed but I'm sorry I cant work out how to do it with the layouts
I can confirm in Joomla! 3.7.0-staging
Status | Confirmed | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-29 15:36:02 |
Closed_By | ⇒ | brianteeman |
The string is correct here on GitHub: joomla-cms/administrator/language/en-GB/en-GB.com_categories.ini
But it's not up to date in the installed file, version 3.6.0