? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
25 Jul 2016

Big batch of spelling and typos fixed according to style guide (99% are in comments and doc blocks)
https://joomla.github.io/user-interface-text/?user-interface-text/words2watch.md

cb35916 25 Jul 2016 avatar brianteeman email
f2be0a9 25 Jul 2016 avatar brianteeman meta-
avatar brianteeman brianteeman - open - 25 Jul 2016
avatar brianteeman brianteeman - change - 25 Jul 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jul 2016
Category Repository Administration Components Media Manager Language & Strings Modules Templates (admin) Front End
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jul 2016
Labels Added: ? ?
avatar jeckodevelopment
jeckodevelopment - comment - 25 Jul 2016

I have tested this item successfully on #11295
Good job @brianteeman

avatar brianteeman
brianteeman - comment - 25 Jul 2016

@jeckodevelopment Luca its best not to add the milestone until its marked RTC ;)

avatar RonakParmar RonakParmar - test_item - 26 Jul 2016 - Tested successfully
avatar RonakParmar
RonakParmar - comment - 26 Jul 2016

I have tested this item successfully on 5302513


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11295.

avatar alikon alikon - test_item - 26 Jul 2016 - Tested successfully
avatar alikon
alikon - comment - 26 Jul 2016

I have tested this item successfully on 5302513

code review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11295.

avatar brianteeman brianteeman - change - 26 Jul 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 26 Jul 2016

Rtc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11295.

avatar joomla-cms-bot joomla-cms-bot - change - 26 Jul 2016
Labels Added: ?
avatar sonalitailored sonalitailored - test_item - 27 Jul 2016 - Tested successfully
avatar sonalitailored
sonalitailored - comment - 27 Jul 2016

I have tested this item successfully on 5302513

I have tested this item successfully


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11295.

avatar rdeutz
rdeutz - comment - 13 Aug 2016

@brianteeman could you have a look at the merge conflicts, thanks.

avatar joomla-cms-bot joomla-cms-bot - change - 13 Aug 2016
Labels Added: ?
avatar brianteeman
brianteeman - comment - 13 Aug 2016

@wilsonge @rdeutz i tried to resolve conflicts but i just made it worse and reverted my attempt

avatar rdeutz
rdeutz - comment - 14 Aug 2016

I tried to merge it but after fixing the conflicts I have seen that some changes recently made are overwritten e.G. travis.yml and the merge will delete the /tests/unit/unit.test.sh what is wrong. Maybe someone else can give it a try. One suggestion for future PR's, don't make PR's with 500+ files, when you can't be sure it gets merged very soon.

avatar brianteeman
brianteeman - comment - 14 Aug 2016

When I made it I had hoped it would get merged quickly! Plus the TT
insisted I should do one big change and not lots of little ones. Can't win
:)

Thanks for trying. If @wilsonge can't do it I can do it again as I have the
notes still

avatar brianteeman
brianteeman - comment - 14 Aug 2016

creating a new pr - should be quicker

avatar brianteeman
brianteeman - comment - 14 Aug 2016

@zero-24 thanks for trying ;(

avatar zero-24
zero-24 - comment - 14 Aug 2016

please give me one more try.

avatar brianteeman
brianteeman - comment - 14 Aug 2016

woohoo!!!

Thanks @zero-24

@rdeutz this should be ready to merge now

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 Aug 2016

722 files changed??

avatar brianteeman
brianteeman - comment - 14 Aug 2016

Maybe I should continue with me redo of this PR - I am 50% there

avatar zero-24
zero-24 - comment - 14 Aug 2016

hmm sorry that it don't work @brianteeman :(

avatar brianteeman
brianteeman - comment - 14 Aug 2016

Closed - please try the redo #11604

avatar brianteeman brianteeman - change - 14 Aug 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-08-14 16:06:29
Closed_By brianteeman
avatar brianteeman brianteeman - change - 14 Aug 2016
Labels Removed: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 14 Aug 2016
Labels Added: ?

Add a Comment

Login with GitHub to post a comment