? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
25 Jul 2016

As mentioned in #11262 the Single Article menu options uses a different layout to the com_content article options (and all other layouts). This PR is not to address that.

This PR just makes all the options for a Single Article menu consistent - see screenshots

Before

singlearticle-before

After

singlearticleafter

avatar brianteeman brianteeman - open - 25 Jul 2016
avatar brianteeman brianteeman - change - 25 Jul 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jul 2016
Category Front End Components
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jul 2016
Labels Added: ?
avatar ggppdk ggppdk - test_item - 25 Jul 2016 - Tested successfully
avatar ggppdk
ggppdk - comment - 25 Jul 2016

I have tested this item successfully on 8ab6306


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11291.

avatar jeckodevelopment
jeckodevelopment - comment - 25 Jul 2016

I've tested this item successfully on 8ab6306

avatar brianteeman brianteeman - change - 25 Jul 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 25 Jul 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11291.

avatar joomla-cms-bot joomla-cms-bot - change - 25 Jul 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 25 Jul 2016
The description was changed
avatar brianteeman brianteeman - edited - 25 Jul 2016
avatar sonalitailored sonalitailored - test_item - 25 Jul 2016 - Tested successfully
avatar sonalitailored
sonalitailored - comment - 25 Jul 2016

I have tested this item successfully on 8ab6306


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11291.

avatar odbhaskaran
odbhaskaran - comment - 25 Jul 2016

Tested the item 8ab6306 successfully additionaly Hide and Show should be interchaged to read as Show and Hide.

avatar infograf768
infograf768 - comment - 25 Jul 2016

Agree with @odbhaskaran
Please interchange Show and Hide + correct tab to space between <option and value for these 2 options. :)

avatar brianteeman
brianteeman - comment - 25 Jul 2016

As you can see the things you are asking to be changed have always been that way - This PR just exposed it ;)

avatar infograf768
infograf768 - comment - 25 Jul 2016

Indeed, then why not correct the tab at the same time?

avatar brianteeman
brianteeman - comment - 25 Jul 2016

I cant see the tab n my editor? Where is it

On 25 July 2016 at 14:16, infograf768 notifications@github.com wrote:

Indeed, then why not correct the tab at the same time?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#11291 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Zn209_R3QLvi5BZwHZkdDlx1VPUks5qZLc7gaJpZM4JT872
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar odbhaskaran
odbhaskaran - comment - 25 Jul 2016

@brianteeman see your own corrected image above under 'Article Info Title' swap the Hide Show buttons

avatar brianteeman
brianteeman - comment - 25 Jul 2016

Check the code

avatar odbhaskaran
odbhaskaran - comment - 25 Jul 2016

Line 86 and 87 in the code need to be swapped, thats all.

avatar jeckodevelopment
jeckodevelopment - comment - 26 Jul 2016

@odbhaskaran it should be ok after 536e8b5

avatar hacki65
hacki65 - comment - 26 Jul 2016

It would be very helpful if the actual status from the global settings can be displayed e.g. as tooltip or right from each option. Is this possible?

avatar odbhaskaran
odbhaskaran - comment - 26 Jul 2016

I have tested this item successfully on 8ab6306 and 536e8b5 which perfects this.

avatar jeckodevelopment
jeckodevelopment - comment - 26 Jul 2016

@hacki65 this PR is in RTC status, maybe you can open an issue on the tracker and wait for a PR with the new feature or try to suggest a PR by yourself.

avatar wilsonge wilsonge - change - 27 Jul 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-07-27 09:29:53
Closed_By wilsonge
avatar wilsonge wilsonge - close - 27 Jul 2016
avatar wilsonge wilsonge - merge - 27 Jul 2016
avatar joomla-cms-bot joomla-cms-bot - close - 27 Jul 2016
avatar infograf768
infograf768 - comment - 27 Jul 2016

@brianteeman

See screenshot below: triangles are tabs, losanges are spaces ?
screen shot 2016-07-27 at 11 32 09

avatar brianteeman
brianteeman - comment - 27 Jul 2016

Can you confirm for me that there is the same issue with lots of the option
value on this file.
If so then I can see it in my editor as it is highliting the "value"
differently if there was a space or a tab before it

On 27 July 2016 at 10:34, infograf768 notifications@github.com wrote:

@brianteeman https://github.com/brianteeman

See screenshot below: triangles are tabs, losanges are spaces ?
[image: screen shot 2016-07-27 at 11 32 09]
https://cloud.githubusercontent.com/assets/869724/17170772/e4f80cf6-53ed-11e6-88d4-b2780cdd5fee.png


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11291 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8bfJ2dMvtO_wpaN8Zn3QZiaFN2gPks5qZyYpgaJpZM4JT872
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Add a Comment

Login with GitHub to post a comment