? Success
Pull Request for # 11195

User tests: Successful: Unsuccessful:

avatar bertmert
bertmert
24 Jul 2016

Pull Request for Issue #11195

"... usability issue that on an update of joomla we tell people to update the cache and right now they are a) mistakenly only cleaning the cache for the site not the admin and b) have to do three extra clicks when it just isnt needed."

Summary of Changes

  • Button Delete All (caches) deletes cache of Site and Administrator indepentend of Filter client_id.

Testing Instructions

If you have the possibility to use cache handlers other than File then please testtesttest, too. Thx!

EDIT: Be aware that if you use Cache Handler Cache_Lite that folders (column "Cache Groups") are not removed but only cache files in it that were created by Cache_Lite! You always will see a "1" in column "Number of Files" after deleting. That's a remaining file index.html in each folder. That's not related to this PR.

  • administrator/index.php?option=com_config
  • - Activate Cache with Cache Handler File
  • - Load some pages in FE and some in BE.
  • administrator/index.php?option=com_cache
  • - Via FTP create a folder /administrator/cache/Unbenannt/ (must be writeable/deleteable for Joomla)
  • - See entries with Filter set to Site
  • - See entries with Filter set to Administrator
  • Change Filter to Site
  • Click on button Delete All
  • Change Filter to Administrator
  • You'll see that all folders are still present including folder /Unbenannt/

Apply patch.

  • Follow the steps above.
  • You'll see that also Administrator folder /Unbenannt/ has been deleted. (Other folders were newly created immediately after they have been deleted.)

  • To see error messages:

  • - Via FTP create a folder /administrator/cache/Unbenannt/ (must be writeable/deleteable for Joomla)
  • - Via FTP create a folder /cache/Unbenannt/ (must be writeable/deleteable for Joomla)
  • - Via FTP create a folder /administrator/cache/Unbenannt1/ (must NOT be writeable/deleteable for Joomla)
  • - Via FTP create a folder /cache/Unbenannt1/ (must NOT be writeable/deleteable for Joomla)
  • Click on Delete All

24-07-_2016_16-34-16


24-07-_2016_16-34-36


24-07-_2016_16-35-30


24-07-_2016_16-35-01


avatar bertmert bertmert - open - 24 Jul 2016
avatar bertmert bertmert - change - 24 Jul 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jul 2016
Category Administration Components
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jul 2016
Labels Added: ?
avatar bertmert bertmert - change - 24 Jul 2016
Title
Fix#11195. com_cache. Button Delete All. Delte Site AND Administrator Cache with 1 click
Fix#11195. com_cache. Button Delete All. Delete Site AND Administrator Cache with 1 click
avatar bertmert bertmert - edited - 24 Jul 2016
avatar bertmert bertmert - change - 24 Jul 2016
The description was changed
avatar bertmert bertmert - edited - 24 Jul 2016
avatar bertmert bertmert - edited - 24 Jul 2016
avatar bertmert bertmert - change - 24 Jul 2016
The description was changed
avatar bertmert bertmert - edited - 24 Jul 2016
avatar bertmert bertmert - change - 24 Jul 2016
Title
Fix#11195. com_cache. Button Delete All. Delete Site AND Administrator Cache with 1 click
Fix#11195. com_cache. Button Delete All. Delete Site AND Administrator cache with 1 click
avatar bertmert bertmert - edited - 24 Jul 2016
avatar bertmert bertmert - edited - 24 Jul 2016
avatar bertmert bertmert - change - 24 Jul 2016
The description was changed
avatar bertmert bertmert - edited - 24 Jul 2016
avatar brianteeman brianteeman - change - 25 Jul 2016
Category Administration Components Administration Cache Components
avatar brianteeman brianteeman - change - 25 Jul 2016
Rel_Number 0 11195
Relation Type Pull Request for
avatar bertmert bertmert - change - 26 Jul 2016
The description was changed
avatar bertmert bertmert - edited - 26 Jul 2016
avatar bertmert bertmert - edited - 26 Jul 2016
avatar brianteeman brianteeman - test_item - 28 Jul 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 28 Jul 2016

I have tested this item successfully on 890747e


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11286.

avatar truptikagathara truptikagathara - test_item - 29 Jul 2016 - Tested successfully
avatar truptikagathara
truptikagathara - comment - 29 Jul 2016

I have tested this item successfully on 890747e


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11286.

avatar brianteeman brianteeman - change - 29 Jul 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 29 Jul 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11286.

avatar joomla-cms-bot joomla-cms-bot - change - 29 Jul 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 13 Aug 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-08-13 18:30:46
Closed_By wilsonge
avatar wilsonge wilsonge - close - 13 Aug 2016
avatar wilsonge wilsonge - merge - 13 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - close - 13 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - change - 13 Aug 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment