? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
23 Jul 2016

Pull Request for Issue #11268

Summary of Changes

Changes the zindex so that popoer will display above the fixed navbar etc

Before

e63f2ba2-50f1-11e6-9d2f-a12b61e1d479

After

aeoq

avatar brianteeman brianteeman - open - 23 Jul 2016
avatar brianteeman brianteeman - change - 23 Jul 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jul 2016
Category Templates (admin) Administration Templates (site) Front End
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jul 2016
Labels Added: ?
avatar alikon alikon - test_item - 24 Jul 2016 - Tested successfully
avatar alikon
alikon - comment - 24 Jul 2016

I have tested this item successfully on c169068


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11276.

avatar bertmert bertmert - test_item - 24 Jul 2016 - Tested successfully
avatar bertmert
bertmert - comment - 24 Jul 2016

I have tested this item successfully on c169068


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11276.

avatar brianteeman brianteeman - change - 24 Jul 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 24 Jul 2016

Rtc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11276.

avatar joomla-cms-bot joomla-cms-bot - change - 24 Jul 2016
Labels Added: ?
avatar odbhaskaran
odbhaskaran - comment - 24 Jul 2016

I have pop up background as black with white text very small and not readable. No change after changing template-rtl.css. But pop-up is correctly aligned.

avatar brianteeman
brianteeman - comment - 24 Jul 2016

You are not on current staging

On 24 Jul 2016 10:58 a.m., "Bhaskaran" notifications@github.com wrote:

I have pop up background as black with white text. No change after
changing template-rtl.css


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#11276 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8futG0Kre0TCmvgfROaFKZ6wkqlAks5qYylMgaJpZM4JTYZf
.

avatar roland-d
roland-d - comment - 24 Jul 2016

@brianteeman There is an issue with this PR. The file templates/protostar/css/template.css shouldn't be part of this PR. This file has already been changed by https://github.com/joomla/joomla-cms/pull/11209/files which has been merged. If you can remove this file, we can merge the PR. Thanks.

avatar brianteeman
brianteeman - comment - 24 Jul 2016

I just edited one file and ran the generatesss.php

I can try again on a new branch tomorrow to see if it is any different

avatar zero-24
zero-24 - comment - 24 Jul 2016

This should be removed from the milestone and closed as it is merged with another PR ;)

avatar brianteeman
brianteeman - comment - 24 Jul 2016

Closed as merged.with #11287

avatar brianteeman brianteeman - change - 24 Jul 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-07-24 16:22:30
Closed_By brianteeman
avatar brianteeman brianteeman - close - 24 Jul 2016
avatar joomla-cms-bot joomla-cms-bot - close - 24 Jul 2016
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jul 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment