?
avatar brianteeman
brianteeman
23 Jul 2016

As can be seen in the screenshot there are two fields with identical names and descriptions for a news feed options
tgps

The code in https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_newsfeeds/config.xml#L103 seems to indicate that they are for the first and second images, or more accurately alternate images.

Can someone confirm if that is the case and then if needed I can either update the strngs or remove the second

avatar brianteeman brianteeman - open - 23 Jul 2016
avatar brianteeman brianteeman - change - 23 Jul 2016
Category Components UI/UX
avatar brianteeman brianteeman - change - 25 Jul 2016
Labels Added: ?
avatar RonakParmar
RonakParmar - comment - 26 Jul 2016

Yes, I can see two field having same label, description text and having same options.
I have checked this file https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_newsfeeds/config.xml#L103 and both fields have same label and description language variable,but name of fields are different.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11270.

avatar rdeutz
rdeutz - comment - 7 Aug 2016

It seems to me named wrong, one is for "image_first" and the other one is for "image_second". Both params are used, I can't say if that makes any sense at all

avatar brianteeman
brianteeman - comment - 7 Aug 2016

Making sense is where I was struggling but if they are both used then I
will just fix the strings. Thanks for double checking.

avatar brianteeman
brianteeman - comment - 8 Aug 2016

Closed as we have a PR #11515

avatar brianteeman brianteeman - change - 8 Aug 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-08-08 09:22:13
Closed_By brianteeman
avatar brianteeman brianteeman - close - 8 Aug 2016

Add a Comment

Login with GitHub to post a comment