[#11265] - Simplify some strings
- Fixed in Code Base
- 16 Aug 2016
- Medium
- Build: staging
- # 11265
- Diff
- brianteeman:showhide
- Error continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This mainly removes use of the word "whether" and standardises some strings to use "show or hide". It is simpler English and more consistent across all the strings
Note if you grep the language files for the word "whether" there may be some instances still present because those language strings are not used any more in core.
Testing - please check for typos
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Language & Strings Administration |
| Labels |
Added:
?
?
|
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
RTC - thanks for testing
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11265.
| Labels |
Added:
?
|
||
@brianteeman could you have a look at the merge conflicts, thanks.
I give up - my local git say it is upto date
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11265.
Travis fails because a script has moved, I going to merge this anyway, hoping the internet will not implode
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-16 21:06:08 |
| Closed_By | ⇒ | rdeutz |
Thanks
| Labels |
Removed:
?
|
||
+MOD_LANGUAGES_FIELD_CACHING_DESC="Use the global cache setting the content of this module or disable caching for this module.<br />This should be set to 'No caching' when using Items Associations."
"setting the content" does not make sense to me.
Should'nt it be?
+MOD_LANGUAGES_FIELD_CACHING_DESC="Use the global cache setting to cache the content of this module or disable caching for this module.<br />This should be set to 'No caching' when using Items Associations."
Somewhat off topic but why can't this module be cached with associations in use? That seems like a bug.
@infograf768 I opened PR #11641 to fix the string.
@mbabker I'm not sure I got your report
The language string JM's pointing out says that mod_languages should have caching disabled if item associations are in use. That doesn't seem right at all.
I have tested this item✅ successfully on 19e40ea
looks good now
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11265.