[#11263] - [installation] Add language var missing in latest merge (PR 11254)
- Fixed in Code Base
- 13 Aug 2016
- Medium
- Build: staging
- # 11263
- Diff
- andrepereiradasilva:patch-7
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for New Issue.
Summary of Changes
I forgot to add the new language var (INSTL_DEFAULTLANGUAGE_COULD_NOT_ADD_ASSOCIATIONS) in #11254
So this PR adds the forgotten new language vars in 69fd2dd#diff-20fa161d539804c0cc96d450ab7ee7a1R194
Also adds missing dots to the end of the other error sentences.
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation Language & Strings |
| Labels |
Added:
?
?
|
||
| Title |
|
||||||
As soon as I've had lunch
can you change all instances of "not able" to "unable"
@andrepereiradasilva rather than revert the #11254 I have changed the current error to a generic error string in e83f468. Can you please revert that change as part of this PR for when this is merged for 3.6.2 (as we are currently in language freeze for 3.6.1)
OK. Will change later.
ok done
@andrepereiradasilva Please can you do this for consistency
can you change all instances of "not able" to "unable"
ok @brianteeman done
I added some comments inline
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11263.
@brianteeman this PR is not for reviewing installation language strings ...
@andrepereiradasilva I am confused then - there are new strings in this PR and they are not correct
lol the only new string is INSTL_DEFAULTLANGUAGE_COULD_NOT_ADD_ASSOCIATIONS .
The other ones i changed because you asked me before ...
@andrepereiradasilva Please can you do this for consistency
can you change all instances of "not able" to "unable"
well lets get them right
On 5 August 2016 at 18:27, andrepereiradasilva notifications@github.com
wrote:
lol the only new string is INSTL_DEFAULTLANGUAGE_COULD_NOT_ADD_ASSOCIATIONS
.The other ones i changed because you asked me before ...
@andrepereiradasilva https://github.com/andrepereiradasilva Please can
you do this for consistency
can you change all instances of "not able" to "unable"—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11263 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8f46fjZovj-KXxsAPW1qfVZg0tBcks5qc3KXgaJpZM4JTWlA
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
@brianteeman i understand your point, but this needs to get merged in 3.6.3 because there is a missing language string.
you can correct the rest of the language string after this PR is merged.
It can still be merged in 3.6.3 - nothing stopping it. We are not in a
freeze.
I have tested this item
on code review
i let english mother tongue people the task to correct the strings if needed
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11263.
just removed the "!" at @brianteeman request
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-13 17:07:59 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
@infograf768 @brianteeman please check the text