? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
22 Jul 2016

Summary of Changes

This PR makes installation process auto create the language associations between the items (menu items, categories and articles) when installing a multilanguage site.

Testing Instructions

  1. Download https://github.com/andrepereiradasilva/joomla-cms/archive/associations-on-install.zip (staging + this PR)

  2. Make a new install with this package

    • In the sample data install step, select None (Required for basic native multilingual site creation)
    • Install two or more languages
    • Select to install sample multilingual content
  3. After install, login to backend and check menu items, categories and articles now have the language associations.

image

1060347 22 Jul 2016 avatar andrepereiradasilva ups
avatar andrepereiradasilva andrepereiradasilva - open - 22 Jul 2016
avatar andrepereiradasilva andrepereiradasilva - change - 22 Jul 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jul 2016
Category Installation
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jul 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 22 Jul 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - edited - 22 Jul 2016
535bf19 22 Jul 2016 avatar andrepereiradasilva cs
avatar infograf768 infograf768 - test_item - 23 Jul 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 23 Jul 2016

I have tested this item successfully on 535bf19

Works fine, although associating home pages menu items is not really necessary as these are associated by default without being recorded in the _associations table.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11254.

avatar dgt41
dgt41 - comment - 23 Jul 2016

@andrepereiradasilva another great improvement! ?

In the sample data install step, select None (Required for basic native multilingual site creation)

The process is rather counter intuitive from UX perspective. I would suggest to move the sample install data after the multilingual step (maybe a simple yes/no button will reveal the option in the case of mono and hide it till the languages are selected.

avatar infograf768
infograf768 - comment - 23 Jul 2016

@dgt41
This would require an important refactoring.
This PR is just for adding associations in the data installed in multingual for the user to understand the process.

avatar bertmert bertmert - test_item - 23 Jul 2016 - Tested successfully
avatar bertmert
bertmert - comment - 23 Jul 2016

I have tested this item successfully on 535bf19


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11254.

avatar brianteeman brianteeman - change - 23 Jul 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 23 Jul 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11254.

avatar joomla-cms-bot joomla-cms-bot - change - 23 Jul 2016
Labels Added: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 23 Jul 2016

grrr conflicts because of 4 line spaces... will fix ...

avatar andrepereiradasilva
andrepereiradasilva - comment - 23 Jul 2016

ok conflicts fixed.
IMO no need to retest or remove the RTC

avatar wilsonge wilsonge - change - 23 Jul 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-07-23 12:20:01
Closed_By wilsonge
avatar wilsonge wilsonge - close - 23 Jul 2016
avatar wilsonge wilsonge - merge - 23 Jul 2016
avatar joomla-cms-bot joomla-cms-bot - close - 23 Jul 2016
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jul 2016
Labels Removed: ?
avatar infograf768
infograf768 - comment - 23 Jul 2016

@wilsonge please revert this and change milestone to 3.6.2

avatar brianteeman
brianteeman - comment - 23 Jul 2016

Why?

avatar infograf768
infograf768 - comment - 23 Jul 2016

because of new necessary lang string
#11263

avatar wilsonge
wilsonge - comment - 23 Jul 2016

Rather than revert I've done a very tacky fix of making it a generic error string (see e83f468) and we will ensure #11263 is merged for 3.6.2

avatar infograf768
infograf768 - comment - 23 Jul 2016

OK. ?

Add a Comment

Login with GitHub to post a comment