[#11241] - #11234 fixed hide color issue
- Fixed in Code Base
- 24 Jul 2016
- Medium
- Build: staging
- # 11241
- Diff
- RonakParmar:11234_contack_show_category_hide_color
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11234 .
Summary of Changes
Added css and class to change the color to red to maintain consistency.
Testing Instructions
- Apply this PR. -Try to add/edit contact at administrator side
- Goto "Display" tab.
- Change " Show Category" field options. in hide option, background is red color, and in another two options background is green color.
- Check Contact global configuration-> check same changes for "Contact Category" field.
Follow instructions of #11234
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components Templates (admin) |
| Labels |
Added:
?
|
||
| Rel_Number | 0 | ⇒ | 11234 |
| Relation Type | ⇒ | Pull Request for |
Sorry this is not correct. You cannot edit the template css file directly you must edit the less file and then use the script to generate the css
I have tested this item
It does make the one option red - but if it is to do that then it also needs to make the other two green which it doesnt
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11241.
I'll write the code to change color of other two option to green and update this PR using less file.
Thanks- can you also check for other com_contact xml files which could have the same change made
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11241.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11241.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11241.
| Status | Pending | ⇒ | Ready to Commit |
roland-d
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-24 12:12:48 |
| Closed_By | ⇒ | roland-d |
I have tested this item✅ successfully on cf9fe7c
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11241.