Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#11237] - Catch execptions when executing database actions

? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
21 Jul 2016

Summary of Changes

JDatabaseDriver::execute() implementations does not return boolean false anymore but throws exceptions on query failures. In places where we're already checking for a false return, convert to a try/catch block.

Testing Instructions

Code review.

avatar mbabker mbabker - open - 21 Jul 2016
avatar mbabker mbabker - change - 21 Jul 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jul 2016
Category ⇒ Administration Components Installation Libraries
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jul 2016
Labels Added: ?
avatar ggppdk ggppdk - test_item - 21 Jul 2016 - Tested successfully
avatar ggppdk
ggppdk - comment - 21 Jul 2016

I have tested this item ✅ successfully on 6f3fed3

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11237.

avatar wilsonge wilsonge - change - 21 Jul 2016
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-07-21 21:28:57
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 21 Jul 2016
avatar wilsonge wilsonge - merge - 21 Jul 2016
avatar wilsonge wilsonge - reference | 6702ac6 - 21 Jul 16
avatar wilsonge wilsonge - merge - 21 Jul 2016
avatar wilsonge wilsonge - close - 21 Jul 2016
avatar wilsonge wilsonge - change - 21 Jul 2016
Milestone Added:
avatar mbabker mbabker - head_ref_deleted - 21 Jul 2016

Add a Comment

Login with GitHub to post a comment