Feeling Lucky
?
[#11235] - New version of PR 6788 (JText::_() Optimizations)
- Fixed in Code Base
- 14 Aug 2016
- Medium
- Build: staging
- # 11235
- Diff
- orware:patch-3
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
Related to
# 6788
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Hopefully this is the fastest way to create a new PR with just the changes needed for the JText::_() optimizations from #6788.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
andrepereiradasilva
- comment
- 21 Jul 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11235.
gunjanpatel
- | Rel_Number | 0 | ⇒ | 6788 |
| Relation Type | ⇒ | Related to |
bertmert
- comment
- 22 Jul 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11235.
| Status | Pending | ⇒ | Ready to Commit |
brianteeman
- comment
- 22 Jul 2016
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-14 15:53:22 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
Hi Andre,
Yes that is correct...I'm only checking for the presence for at least one backslash character (which would show up in all 3 of the cases being checked against for the str_replace call).
If there is at least one backslash then we need to process the str_replace call because there's a strong chance it'll be needed.
If there isn't at least one backslash then we don't need to process the str_replace call.
I believe that covers things correctly.
Mainly what I observed was that the vast majority of our language strings do not contain any of those 3 characters so running the str_replace call all of the time on every since language string was unnecessary (and there are lots of these calls). The extra if statement helps to avoid them with the faster strpos check.