? Success
Pull Request for # 11222

User tests: Successful: Unsuccessful:

avatar nppsbh
nppsbh
21 Jul 2016

I think there are nested forms inside com_joomlaupdate default view, getting validation error on https://validator.w3.org/ or just check HTML source code of the page

Correct nested forms inside com_joomlaupdate default view.

avatar nppsbh nppsbh - change - 21 Jul 2016
Status New Pending
avatar nppsbh nppsbh - open - 21 Jul 2016
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jul 2016
Category Administration Components
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jul 2016
Labels Added: ?
avatar nppsbh nppsbh - change - 21 Jul 2016
The description was changed
avatar brianteeman brianteeman - change - 21 Jul 2016
Rel_Number 0 11222
Relation Type Pull Request for
avatar brianteeman brianteeman - change - 21 Jul 2016
Title
administrator/components/com_joomlaupdate/views/default/tmpl/default.php
nested form in com_joomlaupdate default view
avatar brianteeman brianteeman - change - 21 Jul 2016
Title
administrator/components/com_joomlaupdate/views/default/tmpl/default.php
nested form in com_joomlaupdate default view
avatar brianteeman
brianteeman - comment - 21 Jul 2016

Updated title


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11232.

avatar ggppdk
ggppdk - comment - 21 Jul 2016

I think there are nested forms inside com_joomlaupdate default view, getting validation error on https://validator.w3.org/ or just check HTML source code of the page

This PR does well to fix this

Now about nesting forms, they are allowed by HTML5 they only need the tag attibute form="..." , after adding it,

  • we can use nested forms, without validation errors (i am using this)
  • we can place fields outside the form TAG (i am using this)

e.g. in a modal that is placing form fields directly under body, because of z-index limitations (you have no control of other elements* in document), validating them and then placing them back in their original position

and it used to be that Joomla validation JS supported this,
but then during mootools code removal it was broken

also it is time that JFormField* classes add support for form TAG attribute, and start adding it when flagged to do it

avatar ggppdk
ggppdk - comment - 21 Jul 2016

I can do a couple of PRs if there is agreement about the above

(PRs which are not relevant to current PR now)

if we add support for form="..." tag attribute then in future the forms can be nested again

avatar hardiktailored
hardiktailored - comment - 4 Aug 2016

@ggppdk I had tried form tag too but note that this does not support any IE browsers.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11232.

avatar ggppdk
ggppdk - comment - 4 Aug 2016

You mean the tag attribute "form"

<input form="tagid_of_form_tag" ... />

Yes you are right, but the updated version of IE10 supporting it
so you have IE10 and IE11 supporting it

avatar ggppdk
ggppdk - comment - 4 Aug 2016

About

that this does not support any IE browsers.

Even if Joomla will not make use of it yet (i agree on this), since no support of it in IE8 / IE9 and earlier version of IE10

still the JS code needs to be patched to be ready for it

avatar hardiktailored hardiktailored - test_item - 5 Aug 2016 - Tested successfully
avatar hardiktailored
hardiktailored - comment - 5 Aug 2016

I have tested this item successfully on a483302

Patch removes parent form and everything working as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11232.

avatar hardiktailored
hardiktailored - comment - 5 Aug 2016

@ggppdk Agree.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11232.

avatar hans2103 hans2103 - test_item - 4 Nov 2016 - Tested successfully
avatar hans2103
hans2103 - comment - 4 Nov 2016

I have tested this item successfully on a483302

patch will move form outside form and still works


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11232.

avatar brianteeman brianteeman - change - 8 Nov 2016
The description was changed
Status Pending Ready to Commit
avatar brianteeman brianteeman - edited - 8 Nov 2016
avatar brianteeman
brianteeman - comment - 8 Nov 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11232.

avatar brianteeman brianteeman - change - 8 Nov 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 8 Nov 2016
Milestone Added:
avatar jeckodevelopment
jeckodevelopment - comment - 8 Nov 2016

@brianteeman there's a conflict with this PR
administrator/components/com_joomlaupdate/views/default/tmpl/default.php

avatar roland-d
roland-d - comment - 13 Nov 2016

Merged with commit eb4ddb4

avatar roland-d roland-d - close - 13 Nov 2016
avatar roland-d roland-d - close - 13 Nov 2016
avatar roland-d roland-d - change - 13 Nov 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-11-13 06:12:40
Closed_By roland-d
avatar joomla-cms-bot joomla-cms-bot - change - 13 Nov 2016
Category Administration Components Administration com_joomlaupdate Components

Add a Comment

Login with GitHub to post a comment