User tests: Successful: Unsuccessful:
I think there are nested forms inside com_joomlaupdate default view, getting validation error on https://validator.w3.org/ or just check HTML source code of the page
Correct nested forms inside com_joomlaupdate default view.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Components |
Labels |
Added:
?
|
Rel_Number | 0 | ⇒ | 11222 |
Relation Type | ⇒ | Pull Request for |
Title |
|
Title |
|
I think there are nested forms inside com_joomlaupdate default view, getting validation error on https://validator.w3.org/ or just check HTML source code of the page
This PR does well to fix this
Now about nesting forms, they are allowed by HTML5 they only need the tag attibute form="..." , after adding it,
e.g. in a modal that is placing form fields directly under body, because of z-index limitations (you have no control of other elements* in document), validating them and then placing them back in their original position
and it used to be that Joomla validation JS supported this,
but then during mootools code removal it was broken
also it is time that JFormField* classes add support for form TAG attribute, and start adding it when flagged to do it
I can do a couple of PRs if there is agreement about the above
(PRs which are not relevant to current PR now)
if we add support for form="..." tag attribute then in future the forms can be nested again
@ggppdk I had tried form tag too but note that this does not support any IE browsers.
You mean the tag attribute "form"
<input form="tagid_of_form_tag" ... />
Yes you are right, but the updated version of IE10 supporting it
so you have IE10 and IE11 supporting it
About
that this does not support any IE browsers.
Even if Joomla will not make use of it yet (i agree on this), since no support of it in IE8 / IE9 and earlier version of IE10
still the JS code needs to be patched to be ready for it
I have tested this item
Patch removes parent form and everything working as expected.
@ggppdk Agree.
I have tested this item
patch will move form outside form and still works
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
|
Milestone |
Added: |
@brianteeman there's a conflict with this PR
administrator/components/com_joomlaupdate/views/default/tmpl/default.php
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-13 06:12:40 |
Closed_By | ⇒ | roland-d |
Category | Administration Components | ⇒ | Administration com_joomlaupdate Components |
Updated title
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11232.