? Success

User tests: Successful: Unsuccessful:

avatar JoomliC
JoomliC
20 Jul 2016

Summary of Changes

  • Fix accessibility of last menu items of each dropdown if window viewport height is too small to display the full menu and viewport height is less than 570px
  • Set dynamically max-height for the dropdown menu to adapt window vierport height.
  • Set dynamically the padding-top for the submenus (replace 8 value for offset top by getting parent menu link and dropdown padding-top)

Testing Instructions

  • Apply Patch
  • Clear all caches (admin and browser)
  • Resize your window in order to hide bottom of one or more dropdown menu when opened
  • Mouse over the dropdown, with patch applied, the scrolling will be automatically added if needed (without patch, not possible to access last items of the dropdown)
  • Check if submenu position top is still align with the menu dropdown
  • Play a bit with different window heights to check if behavior is working as expected : last menu items always accessible when hovering the menu)

Before Patch on latest staging :
(to take into account last changes for submenu dynamic position when outside the viewport: #11080 )
capture d ecran 2016-07-20 a 16 37 42

After Patch :
capture d ecran 2016-07-20 a 16 51 34

cc/ @C-Lodder

avatar JoomliC JoomliC - open - 20 Jul 2016
avatar JoomliC JoomliC - change - 20 Jul 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Jul 2016
Labels Added: ?
avatar JoomliC JoomliC - change - 20 Jul 2016
The description was changed
avatar JoomliC JoomliC - change - 20 Jul 2016
The description was changed
avatar JoomliC JoomliC - change - 20 Jul 2016
The description was changed
avatar C-Lodder C-Lodder - test_item - 20 Jul 2016 - Tested successfully
avatar C-Lodder
C-Lodder - comment - 20 Jul 2016

I have tested this item successfully on 5868b9e


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11216.

Thanks @JoomliC

avatar brianteeman brianteeman - change - 20 Jul 2016
Category Administration UI/UX
avatar killoltailored killoltailored - test_item - 21 Jul 2016 - Tested successfully
avatar killoltailored
killoltailored - comment - 21 Jul 2016

I have tested this item successfully on 5868b9e


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11216.

avatar killoltailored
killoltailored - comment - 21 Jul 2016

I have tested this issue successfully with Joomla Version: Joomla! 3.6.1-dev Development [ Noether ] 13-July-2016 10:08 GMT
OS Windows 8.1 and browsers Firefox 47.0.1, Chrome Version 51.0.2704.106 m and Safari 5.1.7
screen shot 2016-07-20 at 22 51 45


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11216.

avatar brianteeman brianteeman - change - 21 Jul 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 21 Jul 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11216.

avatar joomla-cms-bot joomla-cms-bot - change - 21 Jul 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 21 Jul 2016
Milestone Added:
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jul 2016
Category Administration UI/UX Templates (admin) Administration UI/UX
avatar sonalitailored
sonalitailored - comment - 21 Jul 2016

Successfully tested


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11216.

avatar wilsonge wilsonge - change - 21 Jul 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-07-21 11:17:10
Closed_By wilsonge
avatar wilsonge wilsonge - close - 21 Jul 2016
avatar wilsonge wilsonge - merge - 21 Jul 2016
avatar joomla-cms-bot joomla-cms-bot - close - 21 Jul 2016
avatar wilsonge wilsonge - reference | 4de2387 - 21 Jul 16
avatar wilsonge wilsonge - merge - 21 Jul 2016
avatar wilsonge wilsonge - close - 21 Jul 2016
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jul 2016
Labels Removed: ?
avatar JoomliC
JoomliC - comment - 21 Jul 2016

Thanks @C-Lodder @killoltailored @sonalitailored for testing! ?

Add a Comment

Login with GitHub to post a comment