[#11209] - Use alert-link class, change link color for default warning alert
- Fixed in Code Base
- 21 Jul 2016
- Medium
- Build: staging
- # 11209
- Diff
- mbabker:alert-link-use
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Consistently use recently introduced alert-link class for all links in rendered alert divs. Also, changes the color of alert links for the default warning alert div to match its color (and Bootstrap 3's implementation)
Before:
After:
Testing Instructions
In the update component, the link to the download page should now have the "bold" appearance. Same for the link in the stats plugin's nag message and duplicate queries in the debug console's output. Links in warning alerts (default yellow) should now have the brownish appearance instead of blue.
As for the stray CSS change with the .categories-list .collapse selector, that came after running the generatecss.php script. No idea why else it'd be there.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
I have tested for "Same for the link in the stats plugin's nag message and duplicate queries in the debug console's output.".
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11209.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11209.
Tested successfully for "stats plugin's nag message and duplicate queries in the debug console's output"
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11209.
Where I can see the above warning message which you have displayed in screen-dump in description?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11209.
@zero-24 Thank you for the Link, but How to test this link after applying the PR? I have replicated latest staging site in my local system and using patch tester component I am testing all PRs.
So, how can I test this warning message in my local? Or what should I have to do to test the warning message?
Thank you.
@RonakParmar this screenshot was just an example how it looks like ;) for testing you can have a look to the Testing Instructions ;)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11209.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
| Category | ⇒ | Language & Strings UI/UX |
| Milestone |
Added: |
||
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-21 21:23:38 |
| Closed_By | ⇒ | wilsonge |
roland-d
- | Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 0012d07
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11209.