? ? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
19 Jul 2016

Summary of Changes

Consistently use recently introduced alert-link class for all links in rendered alert divs. Also, changes the color of alert links for the default warning alert div to match its color (and Bootstrap 3's implementation)

Before:
screen shot 2016-07-19 at 3 25 17 pm

After:
screen shot 2016-07-19 at 3 25 00 pm

Testing Instructions

In the update component, the link to the download page should now have the "bold" appearance. Same for the link in the stats plugin's nag message and duplicate queries in the debug console's output. Links in warning alerts (default yellow) should now have the brownish appearance instead of blue.

As for the stray CSS change with the .categories-list .collapse selector, that came after running the generatecss.php script. No idea why else it'd be there.

avatar mbabker mbabker - open - 19 Jul 2016
avatar mbabker mbabker - change - 19 Jul 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Jul 2016
Labels Added: ? ?
avatar mbabker mbabker - change - 19 Jul 2016
The description was changed
avatar RonakParmar RonakParmar - test_item - 20 Jul 2016 - Tested successfully
avatar RonakParmar
RonakParmar - comment - 20 Jul 2016

I have tested this item successfully on 0012d07


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11209.

avatar RonakParmar
RonakParmar - comment - 20 Jul 2016

I have tested for "Same for the link in the stats plugin's nag message and duplicate queries in the debug console's output.".


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11209.

avatar killoltailored killoltailored - test_item - 20 Jul 2016 - Tested successfully
avatar killoltailored
killoltailored - comment - 20 Jul 2016

I have tested this item successfully on 0012d07


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11209.

avatar killoltailored
killoltailored - comment - 20 Jul 2016

Tested successfully for "stats plugin's nag message and duplicate queries in the debug console's output"


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11209.

avatar RonakParmar
RonakParmar - comment - 20 Jul 2016

Where I can see the above warning message which you have displayed in screen-dump in description?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11209.

avatar RonakParmar
RonakParmar - comment - 20 Jul 2016

@zero-24 Thank you for the Link, but How to test this link after applying the PR? I have replicated latest staging site in my local system and using patch tester component I am testing all PRs.
So, how can I test this warning message in my local? Or what should I have to do to test the warning message?
Thank you.

avatar zero-24
zero-24 - comment - 20 Jul 2016

@RonakParmar this screenshot was just an example how it looks like ;) for testing you can have a look to the Testing Instructions ;)

avatar RonakParmar
RonakParmar - comment - 20 Jul 2016

Okay got it, Apologize for the misunderstanding, Then I have already tested using system debug console. Thanks for the clarification @zero-24 ?

avatar truptikagathara truptikagathara - test_item - 20 Jul 2016 - Tested successfully
avatar truptikagathara
truptikagathara - comment - 20 Jul 2016

I have tested this item successfully on 0012d07


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11209.

avatar mbabker mbabker - change - 20 Jul 2016
Status Pending Ready to Commit
Labels
avatar brianteeman brianteeman - change - 20 Jul 2016
Category Language & Strings UI/UX
avatar brianteeman brianteeman - change - 20 Jul 2016
Milestone Added:
avatar brianteeman
brianteeman - comment - 21 Jul 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11209.

avatar joomla-cms-bot joomla-cms-bot - change - 21 Jul 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 21 Jul 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-07-21 21:23:38
Closed_By wilsonge
avatar roland-d roland-d - change - 22 Jul 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment