[#11192] - TinyMCE init() issue #11190
- Fixed in Code Base
- 13 Aug 2016
- Medium
- Build: staging
- # 11192
- Diff
- OctavianC:patch-5
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11190 .
Summary of Changes
The $idField variable is never used throughout the code, seems to be an attempt to sanitize the $id. I've added some more filtering to produce a usable id. Should work for multiple editors as well.
Testing Instructions
Testing instructions can be found in the issue description.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
Should be faster, but it doesn't cover all options:
- It extracts the last character, what if my
$nameis simplyeditor? - It doesn't take into account nested names
- Other wrong characters would be allowed
Agree!
brianteeman
- | Category | ⇒ | Plugins |
| Rel_Number | 0 | ⇒ | 11190 |
| Relation Type | ⇒ | Pull Request for |
I have tested this item
tested with class some[name]
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11192.
I have tested this item
Before, using code given in #11190, by default textarea was visible and after applying patch by default TinyMCE gets visible.
Square-brackets([]) replaced with the underscores(_) in name so found no problem in that also.
Tested multiple TinyMCE editors on the same page.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11192.
| Status | Pending | ⇒ | Ready to Commit |
| Category | Plugins | ⇒ | Plugins Front End |
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-13 17:32:21 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
this should be faster:
$id = str_replace('[', '_', substr(trim($name), 0, -1));