Joomla! Issue Tracker | Joomla! CMS #11168 - Fix#11155 Two finder module make invalid HTML for W3C

Fixed in Code Base
28 Jul 2016
Medium
Build: staging
# 11168
Diff
bertmert:patch-8

Success

Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details

Pull Request for # 11155

User tests: Successful: Unsuccessful:

bertmert
18 Jul 2016

Pull Request for Issue #11155 .

Summary of Changes

Added postfix for attributes id and for in HTML and JS.

Testing Instructions

See #11155 please.

Test also with setting autosuggest if there are any conflicts with jquery.autocomplete.min.js

Test also with activated cache in module. I'm not sure...

3d443c9 18 Jul 2016

Add postfix for unique ids

bertmert - open - 18 Jul 2016

bertmert - change - 18 Jul 2016

Status

New

⇒

Pending

joomla-cms-bot - change - 18 Jul 2016

Labels

Added: ?

bertmert - change - 18 Jul 2016

The description was changed

ggppdk - comment - 18 Jul 2016

Nice work but

why use a random number ?
in other cases we use module->id to make the HTML tag IDs unique,

using a random number makes impossible to locate the module by id via CSS or JS

bertmert - comment - 18 Jul 2016

@ggppdk
Yes, you're right. I was a bit tired ;-)

65e5538 18 Jul 2016

Add postfix for unique ids ($module->id)

brianteeman - change - 18 Jul 2016

Category

⇒

Modules

brianteeman - change - 18 Jul 2016

Rel_Number	0	⇒	11155
Relation Type		⇒	Pull Request for

brianteeman - comment - 21 Jul 2016

Doesnt the same change have to be made to mod_search?

bertmert - comment - 21 Jul 2016

@brianteeman

Doesnt the same change have to be made to mod_search?

See new PR #11229
But we have a conflict in template Beez3 then.

ggppdk - test_item - 21 Jul 2016 - Tested successfully

ggppdk - comment - 21 Jul 2016

I have tested this item ✅ successfully on 65e5538

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11168.}

truptikagathara - test_item - 28 Jul 2016 - Tested successfully

truptikagathara - comment - 28 Jul 2016

I have tested this item ✅ successfully on 65e5538

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11168.}

brianteeman - change - 28 Jul 2016

Status

Pending

⇒

Ready to Commit

brianteeman - comment - 28 Jul 2016

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11168.}

joomla-cms-bot - change - 28 Jul 2016

Labels

Added: ?

joomla-cms-bot - change - 28 Jul 2016

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#11168] - Fix#11155 Two finder module make invalid HTML for W3C

Summary of Changes

Testing Instructions

Add a Comment

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2016-07-28 22:23:13
Closed_By		⇒	wilsonge