I have following error in the com_patchtester: Could not connect to GitHub: No commit found for the ref tagroute2

I have tested this item ? unsuccessfully on 40b7c93

*In testing environment i have following tag-urls before the patch:
*

• Red: index.php/tagged-items
• Yellow: index.php/compact-tagged
• Green index.php/component/tags/tag/4-green
• Lime index.php/component/tags/tag/5-lime

after the patch:

• Red: index.php/tagged-items
• Yellow: index.php/compact-tagged
• Green: index.php/all-tags/green
• Lime: index.php/all-tags/lime Red and Yellow is still wrong

  ---

  _{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11166.}

@designbengel that looks perfect to me.

On 23 July 2016 at 13:17, designbengel notifications@github.com wrote:

I have tested this item ? unsuccessfully on 40b7c93
40b7c93

*
In testing environment i have following tag-urls before the patch: *

• Red: index.php/tagged-items
• Yellow: index.php/compact-tagged
• Green index.php/component/tags/tag/4-green
• Lime index.php/component/tags/tag/5-lime

after the patch:

• Red: index.php/tagged-items
• Yellow: index.php/compact-tagged
• Green: index.php/all-tags/green
• Lime: index.php/all-tags/lime Red and Yellow is still wrong ------------------------------ This comment was created with the J!Tracker Application https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/11166 https://issues.joomla.org/tracker/joomla-cms/11166.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11166 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8eD5Za2GvniAJdAgTplfk1LLkrH6ks5qYfg0gaJpZM4JOSyf
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Lime: index.php/all-tags/lime Red and Yellow is still wrong
@designbengel What URL do you expected?
Can you write more details about your menu structure?

If you have menu item for "tagged" or "compact" tags then it takes precedence before "all-tags".

You can have some extra menu item like "/my-extra-featured-sponsored-tags" and it can not be replaced by default tags menu, which is menu item to list of all tags.

Of course you can set parent in menu item which may change it to:
/all-tags/my-extra-featured-sponsored-tags but I have not tested it and it is probably unusable.

Ok i thought it should be index.php/all-tags/red for the red and index.php/all-tags/yellow for the yellow. If it´s good so then i mark it as successful.

If you set menu item with alias "red" for tag 'red' and you want URL like /all-tags/red
then in the right side (menu item edit form, details):

• change menu if you need and
• select parent item (menu item from above menu) to "all-tags"

Ok i thought it should be index.php/all-tags/red for the red and index.php/all-tags/yellow for the yellow. If it´s good so then i mark it as successful.

Yes it is good.

If I read the code right, then this will no longer parse the old URLs correctly. Eg index.php/component/tags/tag/5-lime will result in a 404 because it expects a direct "alias" not "id-alias". Or do I miss something?

Eg index.php/component/tags/tag/5-lime will result in a 404 because it expects a direct "alias" not "id-alias"

It will work correctly.

[UPDATED]

You mentioned about fixSegment method which only add a prefix id if find row.

For index.php/component/tags/tag/5-lime if fixSegment method does not find a row then return $segment not changed, means return '5-lime'.

For index.php/component/tags/tag/lime if fixSegment method finds a row with id=5 then return '5-lime'

Both return the same '5-lime'.

I have tested this item ? unsuccessfully on

After applying patch it removes the ID of tags but not replaces tags/tag/ with tags/ from the URL as you said in first place.
It works as you said for menu items. When menu item is present, tags/tag/ replaces with menu alias name.

See results:

Before applying patch and without menu item

After applying patch without menu item

After applying patch with menu item added

For index.php/component/tags/tag/5-lime if fixSegment method does not find a row then return $segment not changed, means return '5-lime'.

Ah true, missed that one.

After applying patch it removes the ID of tags but not replaces tags/tag/ with tags/ from the URL as you said in first place.

You right,

[updated]
you talk about:
/component/tags/tag NOT /tags/tag

my description was incorrect, I wrote to fast,
I concerned on (SEF enabled) links that have some menu item.

Just checking in on this. Would like to see this make it into J 3.7 ?

This means we need test here @JoshuaLewis ;)

I have tested this item ✅ successfully on 40b7c93

Works quite well. ? Great little PR!

@zero-24 Can you test it as well?

Hi, I report a issue with tags menu items in a multilanguage site.
If a tag menu item (i.e. .../index.php/eventi) is set to all language, the link of the tag in the article is right the same.
If the tag menu item is set to a specific language, the link of the tag in tha article (of the same language) is not correct .../index.php/component/tags/tag/eventi

I tested a 3.6.4 with this patch but the issue still remain. Is ti related or better to open a new tracker?

It is better to create another issue.

@csthomas is this pr still to test?

Yes.

I have tested this item ✅ successfully on 40b7c93

Two good tests here. So I'm setting RTC. BUT I want @rdeutz to review this as I don't know if we want to go down this path or move tags across to "new" routing before we try this...

Seems to me a good change