? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
17 Jul 2016

Summary of Changes

The include helper path in com_menus item, com_users debuguser and com_users debuggroup is not correct and when loading the model will generate a php fatal error.

Testing Instructions

  • Use latest staging
  • Add this lines to isis index.php
JLoader::register('MenusModelItem', JPATH_ADMINISTRATOR . '/components/com_menus/models/item.php');
$model = JModelLegacy::getInstance('Item', 'MenusModel', array('ignore_request' => true));

JLoader::register('UsersModelDebugUser', JPATH_ADMINISTRATOR . '/components/com_users/models/debuguser.php');
$model = JModelLegacy::getInstance('DebugUser', 'UsersModel', array('ignore_request' => true));

JLoader::register('UsersModelDebuggroup', JPATH_ADMINISTRATOR . '/components/com_users/models/debuggroup.php');
$model = JModelLegacy::getInstance('Debuggroup', 'UsersModel', array('ignore_request' => true));
  • Try to load any admin page. You get a Fatal error, you'll notice in the fatal error the patch where is trying to laod the helper is not correct.
Warning: require_once(/path/to/joomla-staging/administrator/components/com_xxxxxx/helpers/menus.php): failed to open stream: No such file or directory in /path/to/joomla-staging/administrator/components/com_menus/models/item.php on line 15
Fatal error: require_once(): Failed opening required '/path/to/joomla-staging/administrator/components/com_xxxxxx/helpers/menus.php' (include_path='/path/to/joomla-staging/') in /path/to/joomla-staging/administrator/components/com_menus/models/item.php on line 15
  • Apply this patch
  • Repeat process and confirm no fatal error now.
  • Check menu itmes works fine and debuguser and debuggroup work fine too
  • Do a simple code review (3 lines of code).

Notes

This problem was discovered when trying to load the menu items model in the GsoC 2016 Improved Multi-lingual Content Management

avatar andrepereiradasilva andrepereiradasilva - open - 17 Jul 2016
avatar andrepereiradasilva andrepereiradasilva - change - 17 Jul 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jul 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 17 Jul 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - change - 17 Jul 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - change - 17 Jul 2016
The description was changed
37f20e2 17 Jul 2016 avatar andrepereiradasilva menus
avatar andrepereiradasilva andrepereiradasilva - change - 17 Jul 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - change - 17 Jul 2016
The description was changed
avatar andrepereiradasilva
andrepereiradasilva - comment - 17 Jul 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 17 Jul 2016

this is solved already in #10881

So i'm gone a close this one.

Please test #10881
thanks @mbabker

avatar andrepereiradasilva andrepereiradasilva - change - 17 Jul 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-07-17 17:05:19
Closed_By andrepereiradasilva
avatar andrepereiradasilva andrepereiradasilva - close - 17 Jul 2016
avatar andrepereiradasilva andrepereiradasilva - close - 17 Jul 2016
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 17 Jul 2016

Add a Comment

Login with GitHub to post a comment