Feeling Lucky
?
[#11153] - Make the tag parameters available
- Fixed in Code Base
- 14 Aug 2016
- Medium
- Build: staging
- # 11153
- Diff
- roland-d:tag-params-availability
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
When rendering tags with the module mod_tags_popular it is not possible to access the settings of the tag itself such as the class of that specific tag. This pull request adds the stored parameters as an option that can be used.
Use-case: styling of tags using the class set for this particular tag.
Testing Instructions
- Go to Components -> Tags
- Edit a tag and set a value in the CSS Class for tag link field
- Save the tag
- Open the file modules\mod_tags_popular\tmpl\default.php
- Check the content of $item, the class value is not available anywhere
- Apply pull request
- Check the content of $item, the param value is now available
The parameters can now be used as:
$tagParams = new \Joomla\Registry\Registry($item->params);
$link_class = $tagParams->get('tag_link_class');@designbengel This one is for you :)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Modules Tags |
nikitadhiman
- comment
- 18 Jul 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11153.
| Status | Pending | ⇒ | Ready to Commit |
brianteeman
- comment
- 20 Jul 2016
| Labels |
Added:
?
|
||
| Category | Modules Tags | ⇒ | Front End Modules |
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-14 15:51:25 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on f71af02
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11153.