Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#11132] - Move travis cs check to php7

? ? Pending

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
14 Jul 2016

Summary of Changes

Just an idea.
In theory php 7.x is faster and uses less memory so move cs check to php 7.x build.

Testing Instructions

Code review

avatar andrepereiradasilva andrepereiradasilva - open - 14 Jul 2016
avatar andrepereiradasilva andrepereiradasilva - change - 14 Jul 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Jul 2016
Labels Added: ? ?
avatar andrepereiradasilva andrepereiradasilva - change - 14 Jul 2016
The description was changed
avatar mbabker
mbabker - comment - 14 Jul 2016

IIRC PHP_CodeSniffer doesn't properly support PHP 7 on its 1.x branch which is why it's been running on PHP 5.6.

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 Jul 2016

ok closed them

avatar andrepereiradasilva andrepereiradasilva - change - 14 Jul 2016
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-07-14 18:50:46
Closed_By ⇒ andrepereiradasilva
avatar andrepereiradasilva andrepereiradasilva - close - 14 Jul 2016
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 14 Jul 2016
avatar photodude
photodude - comment - 14 Jul 2016

I agree, this should wait until the PHPCS 2.x version of the code standard is completed and released.

Add a Comment

Login with GitHub to post a comment