I have tested this item ✅ successfully on 7c1086f

Hi, I'm new to the github reporting system for Joomla.

Do I need to download an updated file from somewhere and test this (as the original author) or do I just wait until Joomla rolls out an update?

Thanks

Pull Requests (PR) only get Ready to Commit (RTC) state with two success tests.
After RTC is up to joomla mantainers to review them and decide in which version should the patch be released.

To test and mark as success or not you can use the Joomla PatchTester component (install from URL https://github.com/joomla-extensions/patchtester/releases/download/2.0.1/com_patchtester.zip), fetch the data, them apply this patch and test.

When tested go to JIssues (https://issues.joomla.org/tracker/joomla-cms/11120), login with github and mark as success or not.

More info: https://docs.joomla.org/Testing_Joomla!_patches#Recording_test_results

I have tested this item ✅ successfully on 7c1086f

I have tested this item ✅ successfully on 7c1086f

Tested successfully with Joomla Version: Joomla! 3.6.0 Stable [ Noether ] 12-July-2016 21:14 GMT OS: Windows 8.1, Browser: Firefox 47.0.1

This needs to be RTC but a bug on the tracker is preventing it being set

I have tested this item ✅ successfully on 7c1086f

hmm
on Issues, when trying to change to RTC I get

0 UnexpectedValueException

No issue number received.

exception: exception 'UnexpectedValueException' with message 'No issue number received.' in ROOT/src/App/Tracker/Controller/Issue/Save.php:57
Stack trace:
#0 ROOT/src/JTracker/Application.php(170): App\Tracker\Controller\Issue\Save->execute()
#1 ROOT/vendor/joomla/application/src/AbstractWebApplication.php(134): JTracker\Application->doExecute()
#2 ROOT/www/index.php(101): Joomla\Application\AbstractWebApplication->execute()
#3 {main}

@mbabker

@infograf768 See joomla/jissues#834

On 15 July 2016 at 10:58, infograf768 notifications@github.com wrote:

hmm
on Issues, when trying to change to RTC I get

0 UnexpectedValueException

No issue number received.

exception: exception 'UnexpectedValueException' with message 'No issue number received.' in ROOT/src/App/Tracker/Controller/Issue/Save.php:57
Stack trace:
#0 ROOT/src/JTracker/Application.php(170): App\Tracker\Controller\Issue\Save->execute()
#1 ROOT/vendor/joomla/application/src/AbstractWebApplication.php(134): JTracker\Application->doExecute()
#2 ROOT/www/index.php(101): Joomla\Application\AbstractWebApplication->execute()
#3 {main}

@mbabker https://github.com/mbabker

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11120 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8XSHwk8GUH9pOOLa4FdnU5Zj6qC2ks5qV1nAgaJpZM4JMbbO
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

so the RTC works already?

No - still broken

I have tested this item ✅ successfully on 7c1086f

I have tested this item successfully

@itfidds In case if you need more information about contributing You may follow the guides from here https://github.com/joomla/joomla-cms#do-you-want-to-improve-joomla
Thanks.

Thanks

On 25 July 2016 at 12:22, George Wilson notifications@github.com wrote:

Merged #11120 #11120.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11120 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABPH8VCNL37L4r4NlsPwWjgh1YwNuRsiks5qZJxlgaJpZM4JMbbO
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/