[#11086] - Use correct parameter type (Fix #11082)
- Fixed in Code Base
- 16 Jul 2016
- Medium
- Build: staging
- # 11086
- Diff
- mbabker:FTP-param
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11082
Summary of Changes
The third parameter is typehinted as an array so passing a null value is not allowed. Pass an array instead.
Testing Instructions
Code review.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Installation Libraries |
I have tested this item
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11086.
| Status | Pending | ⇒ | Ready to Commit |
RTC
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
roland-d
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-16 13:31:56 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
The same change is needed on line 488 of the same file (file.php)
@hkimgman - please create a new issue or even better a pull request.
CComments on closed Pull Releases will not get seen
Thank you, will do
On Tue, Aug 2, 2016 at 12:53 PM, Brian Teeman notifications@github.com
wrote:
@hkimgman - please create a new issue or even better a pull request.
CComments on closed Pull Releases will not get seen—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11086 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABCw0nsTN-6nvWZpRm1NwkLW1n4VLEwLks5qb6AngaJpZM4JK6wt
.
Henry Kingman
Winnemucca Web Works, LLC
http://WinWebWorks.com/
775 375-8293
henry@winwebworks.com
Hi. I cannot upgrade any of my sites from 3.6.0 to 3.6.1 because as @hkingman states line 488 needs a change as well. I get this error:
Catchable fatal error: Argument 3 passed to JClientFtp::getInstance() must be of the type array, null given, called in /libraries/joomla/filesystem/file.php on line 488 and defined in /libraries/joomla/client/ftp.php on line 194
Edit: Disabling the FTP layer in site configuration solved the issue so that I managed to upgrade.
just change null to array() on line 488. The change was pulled, but I guess
it didn't make it into 3.6.0
On Aug 4, 2016 1:25 AM, "hakanara" notifications@github.com wrote:
Hi. I cannot upgrade any of my sites from 3.6.0 to 3.6.1 because as
hkingman states line 488 needs a change as well. I get this error:Catchable fatal error: Argument 3 passed to JClientFtp::getInstance() must
be of the type array, null given, called in /libraries/joomla/filesystem/file.php
on line 488 and defined in /libraries/joomla/client/ftp.php on line 194Shall I wait for a new update? Even though a new update comes, I cannot
patch it since the updater does not work. I am not sure how to proceed.
Please advise. This situation affects more than 5 sites.—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11086 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABCw0vLLKK4GD2hvH-I3grCsGi4Clz2Aks5qcaHbgaJpZM4JK6wt
.
but I guess it didn't make it into 3.6.0
how could this be done ;) It is shipped with 3.6.1
I have tested this item✅ successfully on b47f466
On review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11086.