[#11064] - Only build list array if function exists
- Fixed in Code Base
- 13 Aug 2016
- Medium
- Build: staging
- # 11064
- Diff
- mbabker:pagination-footer-data
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
The $list data array is only used if the pagination_list_footer() function exists in the template. So only build it if the function exists.
Testing Instructions
No change to how pagination is built. Sorry, off hand I don't know the trace to get this specific function to trigger.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Libraries |
I have tested this item
All paginations below list views like
administrator/index.php?option=com_content
administrator/index.php?option=com_contact
...
work correctly after patch.
After removing
/administrator/templates/isis/html/pagination.php
or deleting function pagination_list_footer(...) in it
$list stays empty and paginations are provided by getPaginationLinks() instead.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11064.
I have tested this item
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11064.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-13 18:24:22 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
@mbabker Travis is failing can you have a look / restart https://travis-ci.org/joomla/joomla-cms/jobs/143719779