? ? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
8 Jul 2016

Summary of Changes

  • Improves doc blocks
  • Calls non-static methods using $this instead of static accessor
  • Simplify some lines as able
  • Access database object from within the model instance versus JFactory
  • Access database object via getter versus direct property use

Testing Instructions

Review

avatar mbabker mbabker - open - 8 Jul 2016
avatar mbabker mbabker - change - 8 Jul 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Jul 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 8 Jul 2016
Category Libraries
avatar joomla-cms-bot joomla-cms-bot - change - 8 Jul 2016
Labels Added: ?
avatar RonakParmar RonakParmar - test_item - 11 Jul 2016 - Tested successfully
avatar RonakParmar
RonakParmar - comment - 11 Jul 2016

I have tested this item successfully on 73d7528


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11057.

avatar brianteeman brianteeman - change - 12 Jul 2016
Category Libraries Libraries Unit Tests
avatar brianteeman brianteeman - change - 12 Jul 2016
Labels
avatar wilsonge
wilsonge - comment - 23 Jul 2016

Conflicts here please

avatar brianteeman
brianteeman - comment - 2 Aug 2016

@mbabker thanks for fixing the merge conflicts

avatar wilsonge wilsonge - change - 2 Aug 2016
Milestone Added:
Status Pending Ready to Commit
Labels
avatar wilsonge
wilsonge - comment - 2 Aug 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11057.

avatar joomla-cms-bot joomla-cms-bot - change - 2 Aug 2016
Labels Added: ?
avatar truptikagathara truptikagathara - test_item - 15 Aug 2016 - Tested successfully
avatar truptikagathara
truptikagathara - comment - 15 Aug 2016

I have tested this item successfully on 5d859ca


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11057.

avatar wilsonge wilsonge - change - 15 Aug 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-08-15 10:24:55
Closed_By wilsonge
avatar brianteeman brianteeman - change - 18 Aug 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment