[#11046] - Add ability to refresh cached JTable fields (getFields patch)
- Closed
- 4 Sep 2016
- Medium
- Build: staging
- # 11046
- Diff
- alex7r:alex7r-Jtable-patch-1
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Add ability to refresh cached JTable fields
Testing Instructions
No built-in use cases
But needed in advanced features coding
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
gunjanpatel
- | Category | ⇒ | Cache |
I guess that the people you need to review this have all been really busy
the last few weeks preparing the release of 3.6
I have tested this item
Tested this in my software, also various Joomla views
Did a code review too and change is correct.
Did a quick look for Joomla built-in code using the method, none of the method calls is currently passing any parameters, this should be safe change
@alex7r
About title of this PR: "JTable getFields patch" Should be changed to ? : "Add ability to refresh cached JTable fields"
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11046.
| Title |
|
||||||
| Category | Cache | ⇒ | Libraries Cache |
The general rule is that all PR require at least two tests
Is my test is counting?
Sadly not - we assume that you wouldnt submit non working code ;)
@brianteeman so it makes 3 Human Tests
Ok, I'll try to bring someone in to test this.
I've successfully tested this.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11046.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11046.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11046.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
rdeutz
- | Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-04 00:50:35 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
Well, 2 days before 2 months, pretty quick. =)
Will some one looks at this and say something?