Feeling Lucky
?
[#11035] - Run SEF plugin also when SEF URLs are not enabled
- Fixed in Code Base
- 5 Oct 2016
- Medium
- Build: 3.7.x
- # 11035
- Diff
- Hackwar:patch-4
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 0 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This change enables the SEF plugin to run even when the SEF URLs are not enabled. The background is, that with the new routing system the component routers are always invoked and called with each URL in order to do the necessary changes, especially setting the right Itemid. Without this change, the URLs everywhere are processed, except for those in content, when the SEF URLs are disabled. That means that with the new system, URLs in content would not get the right Itemid.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Plugins Router / SEF |
| Labels |
Added:
?
Removed: ? |
||
| Category | Plugins Router / SEF | ⇒ | Plugins Front End Router / SEF |
| Labels |
Added:
?
|
||
Hackwar
- comment
- 2 Oct 2016
- Use 3.7-dev as base branch
- Disable SEF URLs
- Get a URL of an article and remove the Itemid
- Paste the URL into a link in an article
- Look at the article with the URL in the frontend and see that the Itemid is still missing.
- Apply this PR
- Reload the article with the URL in the frontend again and see that the Itemid is properly added.
wilsonge
- comment
- 5 Oct 2016
Based on Hannes and myself discussion earlier I am merging this on review to help the testing of the 3.7.x router
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-05 20:22:26 |
| Closed_By | ⇒ | wilsonge |
I have not tested this item.
I copied one article URL when SEF enabled and added in content of another article. Then I disabled the SEF and checked the URL, it doesn't work and redirecting me to the home page. Then I applied patch and again visited the same URL from article, this time also redirected me to home page.
The URL looks same in both the cases. I don't find any URL or parameters changes or anything.
One difference though, before applying patch home page image was not loading and after patch image loads.
Can you please provide more details on how to test? Do I need menu item to test this?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11035.