[#11010] - Add baseurl to user.css in Protostar/Beez3 templates
- Fixed in Code Base
- 16 Jul 2016
- Medium
- Build: staging
- Easy Test
- # 11010
- Diff
- bertmert:patch-5
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Added $this->baseurl to addStyleSheet.
Because of a thread in a german forum where this issue was reported some hours ago.
And because of consistency reasons.
Testing Instructions
I know that it's a very bad idea to deactivate Joomla SEF Plugin but it's allowed and possible.
Addition: Test with beez3 template, too.
Addition2: Test with protostar template in offline mode (maintenance mode), too. (Global Configuration > Site Offline: YES).
Create a file /templates/protostar/css/user.css
and enter some lines of CSS.
body div * {
font-size: 36px !important;
}
Protostar will output an absolute href path for this file (created by SEF Plugin).
<link rel="stylesheet" href="/templates/protostar/css/user.css?3ad5..." />
Go to a subpage now.
E.g. in staging package with testing demo datas to
example.org/index.php/single-article
and see that CSS file is still loaded correctly.
Deactivate SEF-Plugin now in backend of Joomla.
Now Ptotostar will output the following LINK (RELATIVE path)
<link rel="stylesheet" href="templates/protostar/css/user.css?3ad5..." />
Go into source code of the page and click the link. You'll get an
Error: 404 Category not found
The browser cannot load the file correctly because is searching in
example.org/index.php/single-article/templates/protostar/css/user.css
instead of
example.org/templates/protostar/css/user.css
Apply patch and try again.
(Thx to Re:Later who asked me to create this PR).
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Title |
|
||||||
| Title |
|
||||||
| Category | ⇒ | Front End Templates (site) |
| Easy | No | ⇒ | Yes |
please do the same in protostar offline.css
https://github.com/joomla/joomla-cms/blob/staging/templates/protostar/offline.php#L72
This PR has received new commits.
CC: @zero-24
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11010.
I have tested this item
code review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11010.
I have tested this item
Tested and confirmed that the issue exists with SEF plugin OFF
On code review changes seem good,
but also tested all 3 changes, after applying patch, the URL of user.css file was correct in all 3
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11010.
| Status | Pending | ⇒ | Ready to Commit |
RTC as 3.6.0 gets delayed maybe @wilsonge can merge this for 3.6.0?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11010.
| Labels |
Added:
?
|
||
| Labels |
Removed:
?
|
||
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
roland-d
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-16 08:59:27 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 95fe6db
Got it. I missed to test the sub site yesterday Thanks. ;)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11010.