[#10998] - Fixes php warning when asset id (ancestor) is not found for whatever …
- Closed
- 3 Sep 2016
- Medium
- Build: staging
- # 10998
- Diff
- regularlabs:patch-1
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
Suggest code below instead:
if (isset(self::$assetPermissionsById[$extensionName][$id]))
{
$collected[] = self::$assetPermissionsById[$extensionName][$id]->rules
}
Consider this a nobrainer, it fixes a rookie mistake referencing data that is unknown to exist.
Should be accepted based on code review!
I prefer to use ifs for negative exceptions only (as much as possible).
So the returns/continues are inside ifs. And the code you want the thing (function/method/loop) to do is outside (under) the ifs/exceptions.
| Category | ⇒ | Libraries |
Noticed that, don't mind it that much, but do consider my code better to read.
The important thing is that this is accepted based on code review.
Please add more information to your issue. Without test instructions and/or any description we will close this issue within 4 weeks. Thanks.
No reply so closed
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-03 21:35:59 |
| Closed_By | ⇒ | brianteeman |
Please add more information to your issue. Without test instructions and/or any description we will close this issue within 4 weeks. Thanks.
This is an automated message from the J!Tracker Application.