I have tested this item ? unsuccessfully on 8fcbdf7

I can see the column but I dont see the header saying Vote

Personally I see no value in this being enabled all the time. It should only ever be enabled if
1. The vote plugin is enabled
and
2. The param "Show Voting" is set to show

Finally dont forget this would need to be enabled for the Hathor admin template

agree with brian

also is the ordering by number votes or vote rating?

It should only ever be enabled if
1. The vote plugin is enabled
and
2. The param "Show Voting" is set to show

? i'll do it next....

also is the ordering by number votes or vote rating?

@andrepereiradasilva should be easy to allow for both (as is, is only "number of votes")

i'll do it next....
p.s.
not so sure was an "interesting feature"

I still don't think it will be useful but if it's going to exist then it should be the best it can be

i think it's useful to allow to sort articles by number of votes or voting count.

i even think this could be expanded to category layouts "Article Order" ordering

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

please don't test still work in progress

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

ok now is testable

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

The idea is good, the things created are working.
I'm missing the Voting order in the Article Order options in the Menu items; Category Blog, Category List, Featured Articles and All Categories.
I'm missing the Show Voting option in Archived Articles menu item while it's available in Category Blog, Category List, Featured Articles and All Categories

Maybe I missed some other checks, but this is what I could find for now.

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

The idea is good, the things created are working.
I'm missing the Voting order in the Article Order options in the Menu items; Category Blog, Category List, Featured Articles and All Categories.
I'm missing the Show Voting option in Archived Articles menu item while it's available in Category Blog, Category List, Featured Articles and All Categories

@conconnl should be ok now, can you check...

not so sure if i've catched them all ?

p.s
@brianteeman sorry for the spam ?

This PR has received new commits.

CC: @brianteeman

@alikon I tested everything again.
I can't find any issues with the newly created options.

Maybe one more addition and then I think we got everything.

On the category list you can choose to display Author and Hits.
I think when you order by Votes you want to show the number of votes.

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

added the menu option

and the frontend view

This PR has received new commits.

CC: @brianteeman

I have tested this item ? unsuccessfully on 05504b2

1. In the admin it appears that the default for Show Votes in List and Show Ratings in List in the menu item is Show. It must be Use Global or it changes the frontend of an existing site on upgrade. Also the default value in the component option must be hide for the same reason

1. In the front end I am getting PHP Parse error: syntax error, unexpected '?' in /****/components/com_content/views/category/tmpl/default_articles.php on line 223

   ---

   _{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10989.}

Also it appears the latest PR loses the ability to see the list of votes etc in the admin but I can still sort - is that correct?

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

1. default

fixed

loses the ability to see the list of votes etc in the admin but I can still sort - is that correct?

dont understand , can you elaborate....

See screenshot of admin

Vote/Rating column appear only when you select one of these:

• vote descending
• vote ascending
• rating descending
• rating ascending

Tried that - nothing showed up and then i got the following error

You have an error in your SQL syntax; check the manual that corresponds
to your MySQL server version for the right syntax to use near 'LIMIT 20' at
line 13 SQL=SELECT a.id, a.title, a.alias, a.checked_out,
a.checked_out_time, a.catid, a.state, a.access, a.created, a.created_by,
a.created_by_alias, a.ordering, a.featured, a.language, a.hits,
a.publish_up, a.publish_down,l.title AS language_title, l.image AS
language_image,uc.name AS editor,ag.title AS access_level,c.title AS
category_title,ua.name AS author_name,COALESCE(NULLIF(ROUND(v.rating_sum /
v.rating_count, 0), 0), 0) AS rating, COALESCE(NULLIF(v.rating_count, 0),
0) as rating_count,COUNT(asso2.id)>1 as association FROM #__content AS a
LEFT JOIN #__languages AS l ON l.lang_code = a.language LEFT JOIN
#__users AS uc ON uc.id=a.checked_out LEFT JOIN #__viewlevels AS ag ON ag.id
= a.access LEFT JOIN #__categories AS c ON c.id = a.catid LEFT JOIN
#__users AS ua ON ua.id = a.created_by LEFT JOIN #__content_rating AS v ON
a.id = v.content_id LEFT JOIN #__associations AS asso ON asso.id = a.id AND
asso.context='com_content.item' LEFT JOIN #__associations AS asso2 ON
asso2.key = asso.key WHERE (a.state = 0 OR a.state = 1) GROUP BY a.id,
l.title, l.image, uc.name, ag.title, c.title, ua.name ORDER BY LIMIT 20 You
have an error in your SQL syntax; check the manual that corresponds to your
MySQL server version for the right syntax to use near '' at line 13
SQL=SELECT a.id, a.title, a.alias, a.checked_out, a.checked_out_time,
a.catid, a.state, a.access, a.created, a.created_by, a.created_by_alias,
a.ordering, a.featured, a.language, a.hits, a.publish_up,
a.publish_down,l.title AS language_title, l.image AS language_image,uc.name
AS editor,ag.title AS access_level,c.title AS category_title,ua.name AS
author_name,COALESCE(NULLIF(ROUND(v.rating_sum / v.rating_count, 0), 0), 0)
AS rating, COALESCE(NULLIF(v.rating_count, 0), 0) as rating_count,COUNT(
asso2.id)>1 as association FROM #__content AS a LEFT JOIN #__languages AS
l ON l.lang_code = a.language LEFT JOIN #__users AS uc ON uc.id=a.checked_out
LEFT JOIN #__viewlevels AS ag ON ag.id = a.access LEFT JOIN #__categories
AS c ON c.id = a.catid LEFT JOIN #__users AS ua ON ua.id = a.created_by
LEFT JOIN #__content_rating AS v ON a.id = v.content_id LEFT JOIN
#__associations AS asso ON asso.id = a.id AND
asso.context='com_content.item' LEFT JOIN #__associations AS asso2 ON
asso2.key = asso.key WHERE (a.state = 0 OR a.state = 1) GROUP BY a.id,
l.title, l.image, uc.name, ag.title, c.title, ua.name ORDER BY

Going out now for the day

On 9 July 2016 at 09:19, Nicola Galgano notifications@github.com wrote:

Vote/Rating column appear only when you select one of these:

• vote descending
• vote ascending
• rating descending
• rating ascending

[image: votessel]
https://cloud.githubusercontent.com/assets/181681/16706915/80bb29cc-45be-11e6-816b-e4a7b6630511.PNG

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10989 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8WbWB6-nQY7dsSBTgEvbwpFWrxauks5qT1mTgaJpZM4JDVHd
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

This PR has received new commits.

CC: @brianteeman

fixed when multilaguage on, sorry

This PR has received new commits.

CC: @brianteeman

Re-applied patch but no columns in the admin

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

@brianteeman
now the vote/rate sort options only appears when the vote plugin is enabled as suggested by @andrepereiradasilva

This PR has received new commits.

CC: @brianteeman

1. I see now that you only get the option to sort by vote/rating when the plugin is enabled. Cant say i am a fan though that the vote and/or rating are only displayed when you sort by those options. We dont do that for hits for example. And you can only see one at a time

2. If you have an existing menu item set to display a list of articles and apply this patch then the votes and ratings are displayed. You have to go and open and save the menu item for them not to be displayed. This will be a real pain on a site with hundreds of menu items.

3. Does it make sense that you can set the menu item for a list of articles to display the rating and votes if the plugin is not enabled? I dont think it does.

   ---

   _{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10989.}

1, 2, 3.

(make sense)

• should look like this if the plugin is enabled (the 2 coloumns are displayed even if the vote/rate order is not selected)

• and the options settings are enabled and setted to the default hide

• with the vote plugin disabled (the 2 coloumns are not displayed nor the vote/rate order sort options)

• and the options settings are unabled

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

closed for conflicts in favour of #11225