User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Title |
|
Title |
|
Category | ⇒ | Templates (admin) |
Title |
|
||||||
Easy | No | ⇒ | Yes |
Title |
|
Rel_Number | 0 | ⇒ | 10972 |
Relation Type | ⇒ | Pull Request for |
Title |
|
Title |
|
Title |
|
@StefanSTS please mark as tested https://issues.joomla.org/tracker/joomla-cms/10987 (after login the Test button appears). See https://docs.joomla.org/Testing_Joomla!_patches#Recording_test_results
I have tested this item
Thanks for the links. Works as expected.
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
Setting for 3.6 as it fixes a bug introduced in 3.6
Milestone |
Added: |
Would already be better imho (although the arrow will not display exactly as it should) without
.navbar .nav > .dropdown.open:after {
right: 10px;
}
for rtl
@infograf768 you're right, i should have checked on RTL!
I remove the rtl declaration for pointer.
There are issue in RTL not yet reported, and i thought it was ok in RTL as PR #9375 was already merged (but not sure it was tested on RTL...)
So, the position top and arrow not displayed is fixed now.
But 2 other issues in RTL : placement of pointer & placement of sub-menu.
It seems that template.js
is not working to get correctly the offset (as i suspected here #10972 (comment) there is maybe something wrong in the script...) @C-Lodder any idea ? (as you did the PR, your help is welcomed, as i don't see yet how to fix it, and keep your auto-scrolling feature...)
This PR has received new commits.
CC: @brianteeman, @StefanSTS
This PR has received new commits.
CC: @brianteeman, @StefanSTS
Status | Ready to Commit | ⇒ | Pending |
Labels |
Removed rtc
Labels |
Removed:
?
|
I have tested this item
I have tested this item
Changed my result having read down to the first successful tests then paged down to the bottom with the extra commits missing infografs input.
This PR has received new commits.
CC: @brianteeman, @StefanSTS, @Twincarb
This PR has received new commits.
CC: @brianteeman, @StefanSTS, @Twincarb
@infograf768 @Twincarb @brianteeman @StefanSTS i have updated this PR to improve a bit the script, and to fix the issue with submenu placement in RTL reported by @infograf768
If you could test again this PR ? (in LTR and RTL language)
Thanks everybody!
Note: @C-Lodder if you have time to look at code, i have redo a bit your script code in template.js, to set the offset of the submenu with no hardcoded value, and changing a bit the way it is handled. Thanks! ;-)
I have tested this item
@JoomliC
I also made a PR with simpler changes to template.js.
https://www.dropbox.com/s/lmbobjg8rj5ly5v/admin_menu.diff?dl=0
diff --git a/administrator/templates/isis/js/template.js b/administrator/templates/isis/js/template.js
index 28eb4ff..d465088 100644
--- a/administrator/templates/isis/js/template.js
+++ b/administrator/templates/isis/js/template.js
@@ -75,6 +75,7 @@
var dropdown = $self.next('.dropdown-menu');
var offset = $self.offset();
- var scroll = $(window).scrollTop() + 5;
+ var scroll = $(window).scrollTop() + 8;
var width = menuWidth - 13;
+ var rtlwidth = menuWidth + 10;
// Set the submenu position
@@ -83,5 +84,5 @@
emptyMenu.css({
top : offset.top - scroll,
- left: offset.left - width
+ left: offset.left - rtlwidth
});
}
I get exactly the same results as your PR, but... in both cases I have issues here with the User Menu and some glitches with the bottom link in each menu with a sub.
Here is a screen recording :
https://www.dropbox.com/s/fhlweqzwmq1s07g/admin_menu_rtl.mp4?dl=0
I have tested this item
Checked in several rtl languages, and also across Chrome, IE, Edge, Firefox. No issues found having cleared the browser cache. Unable to replicate the issues infograf768 found in his video.
@JoomliC
Ok, I found the culprit. All depends on the length of the lang string value in mod_menu.ini
If the value is more than a certain number of characters/glyphs, it breaks the way I show in my video.
For Farsi, which was the language I used,
we have
MOD_MENU_COM_USERS_ADD_LEVEL="ایجاد سطح دسترسی جدید"
and
MOD_MENU_COM_USERS_NOTE_CATEGORIES="مجموعه یادداشت کاربر"
If the value is more than 19 latin characters (or its equivalent in glyphs), in the menu OR the submenu it pushes the submenu by a number of pixels depending on the longest glyph.
@infograf768 Do you have recorded your video with this PR updated, or with your own changes in template.js ?
If with your own changes, the issue is expected because of submenu width is not a fixed one and change for each submenu (that's the reason i subtract the submenu width dynamically to adjust the offset left. ;-) )
I don't have any issue with Farsi with this PR as it is now. Could you do a test with only this PR applied and no custom changes ?
Note: in the updated PR, to fix RTL, i get dynamically the link width (menu link to open the dropdown) and then get too its padding left (this is currently 10px, so that's the reason for the need of "10", but better to get this padding dynamically than statically ;-) ).
And if you check the left position set in RTL for submenu in my PR, you will see that i get the submenu width dynamically too (this is to fix the issue you have with your custom template.js ;-) ) :
left: offsetLeft - (menuWidth - linkWidth) - submenuWidth
So, maybe an issue in your re-test of this PR after update ? (As i don't have the issue you have recorded here in Farsi : https://www.dropbox.com/s/fhlweqzwmq1s07g/admin_menu_rtl.mp4?dl=0 but with your custom code for template.js, it is "normal" to have this issue ;-) )
Thanks!
Cyril
Status | Pending | ⇒ | Ready to Commit |
My mistake somewhere among all the tests sites...
RTC. Thanks.
Labels |
Added:
?
|
You're welcome @infograf768
Thanks everybody for testing!
I have tested this item
I have installed latest staging branch in my local and applied this PR, still having same issue.
I confirm issue
#11013
@RonakParmar
No relation with this PR. Your screenshot is fine and unrelated to the issue you found.
I posted my findings on #11013
What's happening with this. Do I need to look into anything or is it now RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-06 21:14:16 |
Closed_By | ⇒ | wilsonge |
Labels |
Removed:
?
|
I have tested this item✅ successfully on daa3d4d
All good
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10987.