? Success
Pull Request for # 10972

User tests: Successful: Unsuccessful:

avatar JoomliC
JoomliC
1 Jul 2016

Pull Request for Issue #10972.

Summary of Changes

  • Fix missing pointer in dropdown menu
  • Fix sub-menu top placement

Testing Instructions

  • See issue #10972 for more details
avatar JoomliC JoomliC - open - 1 Jul 2016
avatar JoomliC JoomliC - change - 1 Jul 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jul 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 1 Jul 2016
Title
Admin menu dropdown in Joomla! 3.6.0 RC1
Fix for issue #10972 (3.6.0-rc)
avatar JoomliC JoomliC - change - 1 Jul 2016
Title
Patch 32
Fix for issue #10972 (3.6.0-rc)
avatar brianteeman brianteeman - change - 1 Jul 2016
Category Templates (admin)
avatar brianteeman brianteeman - change - 1 Jul 2016
Title
Patch 32
Admin menu dropdown in Joomla! 3.6.0 RC1
Easy No Yes
avatar brianteeman brianteeman - change - 1 Jul 2016
Title
Fix for issue #10972 (3.6.0-rc)
Admin menu dropdown in Joomla! 3.6.0 RC1
avatar brianteeman brianteeman - change - 1 Jul 2016
Rel_Number 0 10972
Relation Type Pull Request for
avatar brianteeman brianteeman - change - 1 Jul 2016
Title
Admin menu dropdown in Joomla! 3.6.0 RC1
Fix for issue #10972 (3.6.0-rc)
avatar brianteeman brianteeman - test_item - 1 Jul 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 1 Jul 2016

I have tested this item successfully on daa3d4d

All good


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10987.

avatar brianteeman brianteeman - change - 1 Jul 2016
Title
Fix for issue #10972 (3.6.0-rc)
Admin menu dropdown in Joomla! 3.6.0 RC1
avatar brianteeman brianteeman - change - 1 Jul 2016
Title
Fix for issue #10972 (3.6.0-rc)
Admin menu dropdown in Joomla! 3.6.0 RC1
avatar brianteeman
brianteeman - comment - 1 Jul 2016

@joomlic bad memory I guess I thought the other PR was yours - thanks for fixing it though

@C-Lodder can you confirm

avatar JoomliC
JoomliC - comment - 1 Jul 2016

@joomlic bad memory I guess I thought the other PR was yours - thanks for fixing it though

This what i thought ;-)
Thanks for test!

avatar StefanSTS
StefanSTS - comment - 1 Jul 2016

Tested and works. Applied Commit SHA: daa3d4d with patch tester.

avatar wojsmol
wojsmol - comment - 1 Jul 2016
avatar StefanSTS StefanSTS - test_item - 1 Jul 2016 - Tested successfully
avatar StefanSTS
StefanSTS - comment - 1 Jul 2016

I have tested this item successfully on daa3d4d

Thanks for the links. Works as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10987.

avatar brianteeman brianteeman - change - 1 Jul 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 1 Jul 2016

Rtc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10987.

avatar joomla-cms-bot joomla-cms-bot - change - 1 Jul 2016
Labels Added: ?
avatar brianteeman
brianteeman - comment - 1 Jul 2016

Setting for 3.6 as it fixes a bug introduced in 3.6


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10987.

avatar brianteeman brianteeman - change - 1 Jul 2016
Milestone Added:
avatar infograf768
infograf768 - comment - 2 Jul 2016

Not sure it should be RTC.
RTL needs more care, before as well as after patch.
Position of sub and arrow.

Before patch

screen shot 2016-07-02 at 08 21 37
After patch

screen shot 2016-07-02 at 08 18 08

avatar infograf768
infograf768 - comment - 2 Jul 2016

Would already be better imho (although the arrow will not display exactly as it should) without

.navbar .nav > .dropdown.open:after {
    right: 10px;
}

for rtl

avatar JoomliC
JoomliC - comment - 2 Jul 2016

@infograf768 you're right, i should have checked on RTL!
I remove the rtl declaration for pointer.
There are issue in RTL not yet reported, and i thought it was ok in RTL as PR #9375 was already merged (but not sure it was tested on RTL...)

So, the position top and arrow not displayed is fixed now.
But 2 other issues in RTL : placement of pointer & placement of sub-menu.

It seems that template.js is not working to get correctly the offset (as i suspected here #10972 (comment) there is maybe something wrong in the script...) @C-Lodder any idea ? (as you did the PR, your help is welcomed, as i don't see yet how to fix it, and keep your auto-scrolling feature...)

avatar joomla-cms-bot
joomla-cms-bot - comment - 2 Jul 2016

This PR has received new commits.

CC: @brianteeman, @StefanSTS


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10987.

avatar joomla-cms-bot
joomla-cms-bot - comment - 2 Jul 2016

This PR has received new commits.

CC: @brianteeman, @StefanSTS


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10987.

avatar brianteeman brianteeman - change - 2 Jul 2016
Status Ready to Commit Pending
Labels
avatar brianteeman
brianteeman - comment - 2 Jul 2016

Removed rtc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10987.

avatar joomla-cms-bot joomla-cms-bot - change - 2 Jul 2016
Labels Removed: ?
avatar Twincarb Twincarb - test_item - 2 Jul 2016 - Tested successfully
avatar Twincarb
Twincarb - comment - 2 Jul 2016

I have tested this item successfully on 8c324ba


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10987.

avatar JoomliC
JoomliC - comment - 2 Jul 2016

@Twincarb not to be tested again yet, as still an issue in RTL that should be fixed ;-)

avatar Twincarb Twincarb - test_item - 2 Jul 2016 - Tested unsuccessfully
avatar Twincarb
Twincarb - comment - 2 Jul 2016

I have tested this item ? unsuccessfully on 8c324ba

Changed my result having read down to the first successful tests then paged down to the bottom with the extra commits missing infografs input.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10987.

avatar joomla-cms-bot
joomla-cms-bot - comment - 2 Jul 2016

This PR has received new commits.

CC: @brianteeman, @StefanSTS, @Twincarb


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10987.

avatar joomla-cms-bot
joomla-cms-bot - comment - 2 Jul 2016

This PR has received new commits.

CC: @brianteeman, @StefanSTS, @Twincarb


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10987.

avatar JoomliC
JoomliC - comment - 2 Jul 2016

@infograf768 @Twincarb @brianteeman @StefanSTS i have updated this PR to improve a bit the script, and to fix the issue with submenu placement in RTL reported by @infograf768

If you could test again this PR ? (in LTR and RTL language)

Thanks everybody!

Note: @C-Lodder if you have time to look at code, i have redo a bit your script code in template.js, to set the offset of the submenu with no hardcoded value, and changing a bit the way it is handled. Thanks! ;-)

avatar dgt41 dgt41 - test_item - 2 Jul 2016 - Tested successfully
avatar dgt41
dgt41 - comment - 2 Jul 2016

I have tested this item successfully on d7442a8


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10987.

avatar infograf768
infograf768 - comment - 3 Jul 2016

@JoomliC
I also made a PR with simpler changes to template.js.
https://www.dropbox.com/s/lmbobjg8rj5ly5v/admin_menu.diff?dl=0

diff --git a/administrator/templates/isis/js/template.js b/administrator/templates/isis/js/template.js
index 28eb4ff..d465088 100644
--- a/administrator/templates/isis/js/template.js
+++ b/administrator/templates/isis/js/template.js
@@ -75,6 +75,7 @@
            var dropdown = $self.next('.dropdown-menu');
            var offset   = $self.offset();
-           var scroll   = $(window).scrollTop() + 5;
+           var scroll   = $(window).scrollTop() + 8;
            var width    = menuWidth - 13;
+           var rtlwidth = menuWidth + 10;

            // Set the submenu position
@@ -83,5 +84,5 @@
                emptyMenu.css({
                    top : offset.top - scroll,
-                   left: offset.left - width
+                   left: offset.left - rtlwidth
                });
            }

I get exactly the same results as your PR, but... in both cases I have issues here with the User Menu and some glitches with the bottom link in each menu with a sub.
Here is a screen recording :
https://www.dropbox.com/s/fhlweqzwmq1s07g/admin_menu_rtl.mp4?dl=0

avatar Twincarb Twincarb - test_item - 3 Jul 2016 - Tested successfully
avatar Twincarb
Twincarb - comment - 3 Jul 2016

I have tested this item successfully on d7442a8

Checked in several rtl languages, and also across Chrome, IE, Edge, Firefox. No issues found having cleared the browser cache. Unable to replicate the issues infograf768 found in his video.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10987.

avatar infograf768
infograf768 - comment - 3 Jul 2016

@JoomliC
Ok, I found the culprit. All depends on the length of the lang string value in mod_menu.ini
If the value is more than a certain number of characters/glyphs, it breaks the way I show in my video.
For Farsi, which was the language I used,
we have
MOD_MENU_COM_USERS_ADD_LEVEL="ایجاد سطح دسترسی جدید"
and
MOD_MENU_COM_USERS_NOTE_CATEGORIES="مجموعه یادداشت کاربر"

If the value is more than 19 latin characters (or its equivalent in glyphs), in the menu OR the submenu it pushes the submenu by a number of pixels depending on the longest glyph.

avatar JoomliC
JoomliC - comment - 3 Jul 2016

@infograf768 Do you have recorded your video with this PR updated, or with your own changes in template.js ?
If with your own changes, the issue is expected because of submenu width is not a fixed one and change for each submenu (that's the reason i subtract the submenu width dynamically to adjust the offset left. ;-) )

I don't have any issue with Farsi with this PR as it is now. Could you do a test with only this PR applied and no custom changes ?

Note: in the updated PR, to fix RTL, i get dynamically the link width (menu link to open the dropdown) and then get too its padding left (this is currently 10px, so that's the reason for the need of "10", but better to get this padding dynamically than statically ;-) ).
And if you check the left position set in RTL for submenu in my PR, you will see that i get the submenu width dynamically too (this is to fix the issue you have with your custom template.js ;-) ) :
left: offsetLeft - (menuWidth - linkWidth) - submenuWidth

So, maybe an issue in your re-test of this PR after update ? (As i don't have the issue you have recorded here in Farsi : https://www.dropbox.com/s/fhlweqzwmq1s07g/admin_menu_rtl.mp4?dl=0 but with your custom code for template.js, it is "normal" to have this issue ;-) )

Thanks!
Cyril

avatar infograf768 infograf768 - change - 3 Jul 2016
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 3 Jul 2016

My mistake somewhere among all the tests sites...

RTC. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10987.

avatar joomla-cms-bot joomla-cms-bot - change - 3 Jul 2016
Labels Added: ?
avatar JoomliC
JoomliC - comment - 3 Jul 2016

You're welcome @infograf768 ?

Thanks everybody for testing!

avatar infograf768
infograf768 - comment - 4 Jul 2016

@JoomliC
Please look at #11013
I don't have any test sites here with so many components.

avatar RonakParmar RonakParmar - test_item - 4 Jul 2016 - Tested unsuccessfully
avatar RonakParmar
RonakParmar - comment - 4 Jul 2016

I have tested this item ? unsuccessfully on d7442a8


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10987.

avatar RonakParmar
RonakParmar - comment - 4 Jul 2016

I have installed latest staging branch in my local and applied this PR, still having same issue.screen shot 2016-07-04 at 01 28 51


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10987.

avatar infograf768
infograf768 - comment - 4 Jul 2016

I confirm issue
#11013

@RonakParmar
No relation with this PR. Your screenshot is fine and unrelated to the issue you found.
I posted my findings on #11013

avatar infograf768 infograf768 - alter_testresult - 4 Jul 2016 - RonakParmar: Not tested
avatar C-Lodder
C-Lodder - comment - 5 Jul 2016

What's happening with this. Do I need to look into anything or is it now RTC

avatar infograf768
infograf768 - comment - 5 Jul 2016

It is RTC.
@wilsonge

I suggest this goes into next RC.

avatar wilsonge wilsonge - change - 6 Jul 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-07-06 21:14:16
Closed_By wilsonge
avatar wilsonge wilsonge - close - 6 Jul 2016
avatar wilsonge wilsonge - merge - 6 Jul 2016
avatar joomla-cms-bot joomla-cms-bot - close - 6 Jul 2016
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jul 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment