[#10985] - PHP Notice: Undefined variable $data
- Fixed in Code Base
- 3 Jul 2016
- Medium
- Build: staging
- # 10985
- Diff
- demis-palma:fix-logout
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
PHP Notice: Undefined variable: data in [...]/components/com_users/controllers/user.php on line 207.
Testing Instructions
Login into the front-end using the component, or the module as you prefer.
URL if you want to use the component:
http://localhost/index.php?option=com_users&view=loginLogout by the front-end using the component, or the module as you prefer.
If you want to use the component again, call the URL:
http://localhost/index.php?option=com_users&view=login and press "logout".Check the error log of your web-server for the PHP notice mentioned above.
Summary of Changes
The variable $data does not exist. The piece of code that refers to $data has been clearly copied and pasted by the login() method about 120 lines above, but the context of logout() method is slightly different, and does not provide the variable $data as the login() actually does.
Rewritten the related code accordingly.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Authentication |
| Labels |
Added:
?
|
||
I have tested this item
Confirmed issue and confirmed fix
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10985.
I have tested this item
works as described.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10985.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
I guess this has to go into 3.6.0 next RC
| Milestone |
Added: |
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-03 13:43:36 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
This has tottaly broken logout redirection... I should have tested...
Another side effect solved by this patch, is that the check that prevents from using external return URLs did not work, of course, as it relied on a variable that didn't exist ($data).
Now the check that prevents from using external return URLs has been restored.