[#10982] - Move pagination list rendering to layout
- Closed
- 30 Jul 2016
- Medium
- Build: staging
- # 10982
- Diff
- Digital-Peak:pagination-list-layout
User tests: Successful: Unsuccessful:
Summary of Changes
The pagination list rendering is moved to a layout.
Testing Instructions
- Create a lot of articles with featured set to yes
- Open the site on the front
On the default start page on the bottom should the pagination list be shown. The list should look the same as without the patch.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Category | ⇒ | Layout Libraries |
| Labels |
Added:
?
|
||
I have tested this item
works as described
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10982.
I have tested this item
works as expected
Before:
After:
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10982.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
| Labels |
Added:
?
|
||
| Title |
|
||||||
| Title |
|
||||||
This PR has received new commits.
CC: @andrepereiradasilva, @yvesh
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10982.
I have tested this item
just unit test changed.
no change in behaviour
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10982.
IMO it doesn't need testing again as I simplified the unit tests only.
| Status | Ready to Commit | ⇒ | Pending |
| Labels | |||
Remove RTC for now
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10982.
| Labels |
Removed:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10982.
Thanks for testing again.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
back to rtc
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10982.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Category | Layout Libraries | ⇒ | Administration Layout Libraries Unit Tests |
| Labels | |||
| Labels | |||
Last commit improved code style from PR @ Digital-Peak-Incubator/tpl_tauristar#94.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-30 14:16:24 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
If you're going to do this then the
pagination_list_render()overriding function should be deprecated as well. Otherwise you get into the whole "there are multiple ways to override this and depending on which way your template has chosen can affect how you edit it" thing.