? Pending

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
29 Jun 2016

Pull Request for Issue joomla-extensions/weblinks#223

Summary of Changes

Just adding a class clearfix in the container div of the XTD-buttons

Testing Instructions

Apply patch and then test joomla-extensions/weblinks#223

avatar dgt41 dgt41 - open - 29 Jun 2016
avatar dgt41 dgt41 - change - 29 Jun 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jun 2016
Labels Added: ?
avatar yvesh yvesh - test_item - 29 Jun 2016 - Tested unsuccessfully
avatar yvesh
yvesh - comment - 29 Jun 2016

I have tested this item ? unsuccessfully on 74c18ea

Not working for me. The div (editor-xtd-buttons) you added the clearfix has the pull-left. (Wrong level for clearfix)

When you want to fix the issue with clearfix, you have to add it to the parent div before.. (not in that file and from JForm so not really possible)

<div class="controls clearfix">
..

would work.

screenshot 2016-06-29 22 29 57


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10970.

avatar joomla-cms-bot
joomla-cms-bot - comment - 29 Jun 2016

This PR has received new commits.

CC: @yvesh


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10970.

avatar brianteeman brianteeman - change - 29 Jun 2016
Category Plugins
avatar dgt41
dgt41 - comment - 29 Jun 2016

@yvesh you're right that's not the correct place

avatar dgt41 dgt41 - change - 29 Jun 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-06-29 20:37:29
Closed_By dgt41
avatar dgt41 dgt41 - close - 29 Jun 2016
avatar dgt41 dgt41 - close - 29 Jun 2016
avatar dgt41 dgt41 - head_ref_deleted - 29 Jun 2016
avatar yvesh
yvesh - comment - 29 Jun 2016

@dgt41 Now it only would work with TinyMCE (where this issue is not showing up at all) :( We need also a solution for no editor, codemirror and every other editor.

Sorry!

Add a Comment

Login with GitHub to post a comment