Feeling Lucky
?
[#10967] - [Send Test Mail] Javascript green message should have "Message" title
- Fixed in Code Base
- 16 Jul 2016
- Medium
- Build: staging
- # 10967
- Diff
- andrepereiradasilva:patch-18
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Very simple PR: the send test mail message type should be message, not success.
There is no success message type.
Types of messages:
-
message: green -
warning: yellow -
notice: blue -
error: red
Note that all other send test mail messages (error warnings) have the title.
Testing Instructions
Code review.
But if you really want to test:
- Before patch "Send Test mail" message when a link is sent the resulting js green message doesn't have title.
- After patch there is a "Message" title in the green message (like already works in case of warnings or errors).
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
wojsmol
- comment
- 29 Jun 2016
I have tested this item
code review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10967.
| Category | ⇒ | Code style |
| Status | Pending | ⇒ | Ready to Commit |
brianteeman
- comment
- 29 Jun 2016
| Labels |
Added:
?
|
||
BurtNL
- comment
- 29 Jun 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10967.
| Milestone |
Added: |
||
roland-d
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-16 08:33:11 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on ebba6b8
As described, after patch the message text and color are the same, but also there is a title "Message"
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10967.