? ? ? Failure

User tests: Successful: Unsuccessful:

avatar izharaazmi
izharaazmi
29 Jun 2016

Summary of Changes

  1. Push up the destructor from various database drivers to their parent abstract class JDatabaseDriver as it almost every time just does one thing viz disconnect(). Otherwise it can always be overridden.
  2. Never unset class property. $this->connection set to null in disconnect methods of the db drivers.
  3. Nosql connect return type is void not bool.

Testing Instructions

Make sure the disconnect / connect using all the database drivers work correctly without any warning/notice.

Without this patch calling disconnect followed by connect will raise PHP warning. After this patch it should work fine.

avatar izharaazmi izharaazmi - open - 29 Jun 2016
avatar izharaazmi izharaazmi - change - 29 Jun 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jun 2016
Labels Added: ? ?
avatar brianteeman brianteeman - change - 29 Jun 2016
Labels
avatar brianteeman brianteeman - change - 29 Jun 2016
Category Libraries
avatar brianteeman brianteeman - change - 12 Jul 2016
Category Libraries Libraries Unit Tests
avatar izharaazmi
izharaazmi - comment - 11 Apr 2017

Any review on this please?

avatar izharaazmi izharaazmi - change - 12 Apr 2017
The description was changed
Labels
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2017
Category Libraries Unit Tests Libraries Postgresql MS SQL Unit Tests
avatar zero-24 zero-24 - change - 22 May 2017
Milestone Added:
avatar rdeutz rdeutz - change - 23 Jun 2017
Milestone Removed:
avatar rdeutz rdeutz - change - 23 Jun 2017
Milestone Added:
avatar rdeutz rdeutz - change - 23 Jun 2017
Milestone Added:
avatar rdeutz rdeutz - change - 23 Jun 2017
Milestone Removed:
avatar mbabker mbabker - change - 19 Jul 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-19 12:10:33
Closed_By mbabker
avatar mbabker mbabker - close - 19 Jul 2017
avatar mbabker mbabker - merge - 19 Jul 2017

Add a Comment

Login with GitHub to post a comment