[#10945] - JFormFieldUser Duplicate Queries
- Fixed in Code Base
- 16 Jul 2016
- Medium
- Build: staging
- # 10945
- Diff
- kavadas:staging
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
JFormFieldUser is using the JTableUser directly and not the JFactory::getUser. This can generate duplicate queries in case multiple fields are rendered with the same value/user id.
Testing Instructions
Enable the system debugger and try to edit one article which has the same value for "created_by" and "modified_by" fields. When the edit page is loaded, look at the debugger and you will see duplicate queries coming from JFormFieldUser. With the patch applied you should see no duplicate queries from JFormFieldUser.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Fields Libraries |
That'd be totally appropriate. Looks fine to me.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10945.
I have tested this item
Before 52 queries and 16 duplicates, after patch it's 48 queries and 12 duplicates. Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10945.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
roland-d
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-16 14:46:01 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
Might I suggest using
JUser::getInstance()instead ofJFactory::getUser()as the latter will always load a user instance out of the session before going on to callJUser::getInstance()anyway. The instance caching is inJUserso there's only small gains to be had here.