[#10920] - User save profile: read requested data from session after form validation failed
- Fixed in Code Base
- 25 Jul 2016
- Medium
- Build: staging
- # 10920
- Diff
- csthomas:userprofile
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
[front-end] On save user profile, read requested data from session after form validation failed.
Testing Instructions
I believe that code review should be enough.
Please compare to https://github.com/joomla/joomla-cms/blob/staging/components/com_users/controllers/registration.php
Otherwise
Front-end:
[before and after patch]
Go to user profile view, next to edit form and try to save some changes.
For valid changes/data there won't be any difference.
After patch for saving invalid data there will be difference,
because invalid/request data will be load from session
and the user won't need to re-change valid fields again.
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
I have tested this item
It works normally as it should. Only changes in code style - variable name.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10920.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Category | ⇒ | Code style Front End |
roland-d
- | Milestone |
Added: |
||
Before this can be merged you need to ensure that passwords are removed from this form. We do not want any passwords being saved into the user session
| Status | Ready to Commit | ⇒ | Pending |
| Labels | |||
Removing RTC so we can get this change
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10920.
| Labels |
Removed:
?
|
||
| Category | Code style Front End | ⇒ | Front End Components Code style |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-25 09:12:50 |
| Closed_By | ⇒ | wilsonge |
Thankyou very much! Merged :)
I have tested this item✅ successfully on 5e2bacd
I have tested this patch on Joomla 3.6.0 and patch works perfectly. Data is now storing in sessions and after error it repopulates in the fields.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10920.