I have tested this item ✅ successfully on d5320ba

?

I love this way. Thanks

Side note, see with Multilingual Sites...
Is there a way for a "conditional" separator?

This PR has received new commits.

CC: @MATsxm

@MATsxm - done ;)

I have tested this item ? unsuccessfully on 73aff5a

doesn't work on RTL languages (Arabic for instance).

also it seems generatecss.php has not run to generate the css from less files.

After applying the PR my site doesnt look exactly the same as your screenshot. The separator is not evenly spaced

I have tested this item ✅ successfully on 73aff5a

Works fine here with the multilingual mod_ enabled.

Didn't test on RTL

When you only have multilingual mod enabled you have a seperator hanging on
its own

On 23 June 2016 at 17:21, Marc-Antoine Thevenet notifications@github.com
wrote:

I have tested this item ✅ successfully on 73aff5a
73aff5a

Works fine here with the multilingual mod_ enabled.

Didn't test on RTL

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/10918
https://issues.joomla.org/tracker/joomla-cms/10918.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#10918 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8YbIJMts9eGDNSuxuRHY9O3dZQZDks5qOrKdgaJpZM4I87vN
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

When you only have multilingual mod enabled you have a seperator hanging on its own

Yes, because it is a different module maybe better remove it from this module

About RTL it works, if you copy new CSS into the RTL css file (or into the less files),

About extra spacing in seperators it is because of isis CSS rule:

.btn-group + .btn-group {
    margin-left: 5px;
}

And in RTL same effect with extra spacing seperators is because of isis CSS rule:

 .btn-group + .btn-group {
    margin-right: 5px;
    margin-left: 0px;
}

we could add this to fix it:

#status .btn-group + .btn-group {
    margin: 0px;
}

But it seems like and unneeded hack to do this, because the seperator is inside the btn-group, i have tested moving the separator out of the btn-group:

//...  Remove seperator from all $output[] and then:

// Output the items.
/*foreach ($output as $item)
{
    echo $item;
}*/

echo implode('<span class="btn-group separator"></span>', $output);

and the result is proper in both cases (RTL, non-RTL)

Concerning Messages, I guess the tooltip is no more necessary.

@infograf768 - I used new language strings bacause the ones already provided add a number to the beginning of the string, hence the %d. The number is already shown in the badge so no need to show it again.

I'll double check on RTL....always forget this

@C-Lodder
Yep, saw that and deleted my post. ;)
but I still think the tooltip is now useless.

This PR has received new commits.

CC: @andrepereiradasilva, @MATsxm

I've now applied the change to RTL languages and also fixed the whitespace issue as mentioned by @brianteeman

Oh and removed the tooltip

This PR has received new commits.

CC: @andrepereiradasilva, @MATsxm

I have tested this item ✅ successfully on 6d6544e

Sorry to be a pain but because of some stupid rules we dont remove unused strings

This PR has received new commits.

CC: @andrepereiradasilva, @brianteeman, @MATsxm

Added them back in.

Why on earth are language strings that are no longer used not removed?

Don't even go there

I have tested this item ✅ successfully on f14c5a4

Thanks for the great job and a big HA!!!! for the obsolete strings...

I have tested this item ✅ successfully on f14c5a4

RTC

Why on earth are language strings that are no longer used not removed?

Don't even go there

It's about as logical as brexit. #toosoon?

Please alpha order the new lang strings. It should be:

MOD_STATUS_MESSAGES_0="%d Messages"
MOD_STATUS_MESSAGES_1="%d Message"
MOD_STATUS_MESSAGES_LABEL_0="Messages"
MOD_STATUS_MESSAGES_LABEL_1="Message"
MOD_STATUS_MESSAGES_LABEL_MORE="Messages"
MOD_STATUS_MESSAGES_MORE="%d Messages"

Also, It looks likee you did not run correctly the generatecss.php as there is a change in Hathor that was not done by a former css patch I guess. My generatecss also adds this:

diff --git a/administrator/templates/hathor/css/template.css b/administrator/templates/hathor/css/template.css
index 32d3ffe..d61e93c 100644
--- a/administrator/templates/hathor/css/template.css
+++ b/administrator/templates/hathor/css/template.css
@@ -3455,8 +3455,4 @@
    margin-bottom: 10px;
 }
-fieldset.uploadform .control-group,
-fieldset.uploadform .form-actions {
-   display: inline-block;
-}
 #installer-database,
 #installer-discover,

This PR has received new commits.

CC: @andrepereiradasilva, @brianteeman, @MATsxm

@infograf768 - alpha ordered the language strings. No idea what you mean by the generatecss.php. I didn't touch this at all. I simply forked the latest, made my changes, then compiled the LESS using the button in the Isis toolbar

When you modify a .less file you have to run a CLI called generatecss.php, NOT use the Isis compilation.
I.e. cd to your local repository (on Mac it is called Terminal) and enter
php build/generatecss.php
It will do the job for you on the .css files.

@infograf768 - Erm ok, never heard about this before, nor have I ever done it. Is there some sort of "Contributing guidelines" wiki that I can refer to for future reference?

That's for Macintosh
http://www.macworld.co.uk/feature/mac-software/get-more-out-of-os-x-terminal-3608274/
for Linux
https://www.linux.com/learn/how-use-linux-command-line-basics-cli
I guess for windows
http://www.bleepingcomputer.com/tutorials/windows-command-prompt-introduction/

I don't mean that. I mean a guideline as to what steps to take when contributing to Joomla. Where does it say that people need to build the generatecss.php?

It doesn't say it explicitly anywhere but if you make a change to any LESS file in core you should run the generatecss.php script to ensure all resources are correctly updated. Since your changes only affect Isis it probably isn't a major issue this time but if you changed something in the media directory as an example it would affect multiple templates.

@C-Lodder I can't merge this until you run the generatecss.php stuff. I can run you through it if it helps?

I'm removing the RTC label for now

@wilsonge I'll run it tomorrow

@wilsonge - all done

RTC

Bad bot

Come on @joomla-cms-bot