[#10913] - Assocications - Change notice to warning
- Fixed in Code Base
- 16 Jul 2016
- Medium
- Build: staging
- Easy Test
- # 10913
- Diff
- brianteeman:status
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
On a multilingual site if you try to associate an item with Language=All to another language you get a notice that you cant. This should be a warning
Testing Instructions
- On a multilingual site try to associate a contact with language =all to a a contact with a language=en-GB
- On a multilingual site try to associate a newsfeed with language =all to a a contact with a language=en-GB
- On a multilingual site try to associate a content item with language =all to a a contact with a language=en-GB
Before
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Easy | No | ⇒ | Yes |
| Category | ⇒ | Administration UI/UX |
OK I will make it a warning
On 23 June 2016 at 11:42, infograf768 notifications@github.com wrote:
Not sure about that one. We indeed can't associate an item tagged to ALL
languages but we can nevertheless save the item. Maybe a Warning instead of
error?—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#10913 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8Q-FoflEqTv-E5Vu5mXJAf1dHKVjks5qOmMlgaJpZM4I8rE_
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Updated code and instructions to be a warning not an error
| Title |
|
||||||
| Title |
|
||||||
I have tested this item
This works
For another future PR: isn't it possible to just remove the "Associations" tab in this cases, ie, item language set to "All"?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10913.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10913.
| Status | Pending | ⇒ | Ready to Commit |
rtc. thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10913.
| Labels |
Added:
?
|
||
For another future PR: isn't it possible to just remove the "Associations" tab in this cases, ie, item language set to "All"?
Good idea.
I will propose a patch to check in all the various edit.associations views if the item is New and language is set to All. In that case, the Jlayout will not be used and a message will show when displaying the Associations tab.
Something like:
"To use Associations, this item has first to be saved and/or its language set to another language than 'All'."
Maybe use a JGLOBAL string.
@brianteeman
What you think?
I agree in making that patch
Not sure the string is correct but we can look at that when you make the PR
On 24 June 2016 at 11:14, infograf768 notifications@github.com wrote:
I will propose a patch to check in all the various edit.associations views
if the item is New and language is set to All. In that case, the Jlayout
will not be used and a message will show when displaying the Associations
tab.Something like:
"To use Associations, this item has first to be saved and/or its language
set to another language than 'All'."
Maybe use a JGLOBAL string.
@brianteeman https://github.com/brianteeman
What you think?—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10913 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8bG6NgirI3nfu2LF_cp1D7CVdtfDks5qO64QgaJpZM4I8rE_
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
| Milestone |
Added: |
||
roland-d
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-16 08:18:09 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
Not sure about that one. We indeed can't associate an item tagged to ALL languages but we can nevertheless save the item. Maybe a Warning instead of error?