Feeling Lucky
[#1091] - Add bootstrap styling to overrides list
- Closed
- 5 May 2013
- Medium
- Build: master
- # 1091
- Diff
- roland-d:overrides
User tests: Successful: Unsuccessful:
The list with overrides is currently not using the bootstrap markup, this patch fixes that.
nternetinspired
- comment
- 3 May 2013
Thanks Roland.
As noted in the tracker though, the .adminlist is used in Hathor, so we should keep that too, IMO.
nicksavov
- comment
- 3 May 2013
Thanks for coding this, Roland!
For anyone interested, here's the direct link to the tracker item:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30811
Cheers
@roland-d I'd advise against adding an ID to the markup. It's not required for any functionality, and when IDs are used in CSS they cause serious specificity issues.
It's also possible that, .adminlist is used elsewhere, so this change could cause a break there. There's nothing wrong with just amending the existing class with Bootstrap classes though, e.g.:
class="adminlist table table-striped">