[#10906] - Fix non-escaped HTML TAG parameter title for ACL rules selectors, by stripping HTML tags from it
- Fixed in Code Base
- 16 Jul 2016
- Medium
- Build: staging
- # 10906
- Diff
- ggppdk:patch-7
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #10876
Summary of Changes
The title (HTML tag parameter) of the ACL selectors (inherit / allow / deny),
- is not escaped resulting in HTML validation errors, if the title contains HTML
We either need
- to strip HTML tags
- or escape the HTML special characters and add "hasToolTip" class to the ACL inherit / allow / deny selector
This PR suggest to strip HTML tags
Testing Instructions
Open any HTML form with rules and hover over the rules (over the select element: inherit / Allow / Deny), the tooltip should appear (browser native tooltip) without errors
Then add some html to the language string of a rule:
e.g.
<action name="core.create" title="LANG_STRING_WITH_HTML" ... />
The HTML will appear next to the selector but it will be stripped from the browser native tooltip
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10906.
| Status | Pending | ⇒ | Ready to Commit |
Simple correction. RTC. Thanks.
Can go into 3.6.0
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10906.
| Labels |
Added:
?
|
||
brianteeman
- | Labels | |||
| Category | ⇒ | Fields Libraries |
Is this still for 3.6.0? May we have a milestone here?
roland-d
- | Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-16 08:16:42 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 7b1a1b4
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10906.