Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#10902] - Contact "Image" column parameter:

? Success
Pull Request for # 10901
Referenced as Related to: # 10912

User tests: Successful: Unsuccessful:

avatar AlexRed
AlexRed
22 Jun 2016

Pull Request for Issue #10901 .

Summary of Changes

Added ,1 to the parameters to make them show without the need of saving Options

Testing Instructions

Create some contacts and assign an Image to the contacts. Create a menu item type "List Contacts in a Category". In Components > Contacts > Options > List Layouts look the parameter "Image", it is set to Show.
Look in frontend the menu item you created and will see that the image column now is present (and also the filters).

avatar AlexRed AlexRed - open - 22 Jun 2016
avatar AlexRed AlexRed - change - 22 Jun 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jun 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 22 Jun 2016
Title
…
Contact "Image" column parameter
Update default_items.php
avatar brianteeman brianteeman - change - 22 Jun 2016
Category ⇒ Components
avatar brianteeman brianteeman - change - 22 Jun 2016
Title
…
Update default_items.php
Contact "Image" column parameter
Rel_Number 0 ⇒ 10901
Relation Type ⇒ Pull Request for
avatar brianteeman brianteeman - change - 22 Jun 2016
Title
…
Contact "Image" column parameter:
Contact "Image" column parameter
avatar brianteeman brianteeman - change - 22 Jun 2016
Title
…
Update default_items.php
Contact "Image" column parameter
avatar brianteeman brianteeman - change - 22 Jun 2016
Title
…
Update default_items.php
Contact "Image" column parameter:
avatar brianteeman brianteeman - change - 22 Jun 2016
Title
…
Contact "Image" column parameter
Contact "Image" column parameter:
avatar infograf768
infograf768 - comment - 23 Jun 2016

@AlexRed
Can you also correct Beez?

avatar AlexRed
AlexRed - comment - 23 Jun 2016

sorry JM but I don't understand your request, ...I know I'm an idiot :)
I tryed in Beez and I see the image column.

avatar AlexRed AlexRed - reference | ba7de12 - 23 Jun 16
avatar AlexRed
AlexRed - comment - 23 Jun 2016

ok, found how to correct it, see PR #10912

avatar infograf768 infograf768 - test_item - 23 Jun 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 23 Jun 2016

I have tested this item ✅ successfully on 455f7c9

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10902.

avatar infograf768
infograf768 - comment - 23 Jun 2016

To maintainers:
#10912 and this #10902 should be merged together

avatar brianteeman brianteeman - test_item - 23 Jun 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 23 Jun 2016

I have tested this item ✅ successfully on 455f7c9

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10902.

avatar brianteeman brianteeman - change - 23 Jun 2016
Title
…
Contact "Image" column parameter:
Contact "Image" column parameter:
avatar brianteeman brianteeman - change - 23 Jun 2016
Status Pending ⇒ Ready to Commit
avatar brianteeman
brianteeman - comment - 23 Jun 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10902.

avatar joomla-cms-bot joomla-cms-bot - change - 23 Jun 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 13 Jul 2016
Milestone Added:
avatar roland-d
roland-d - comment - 16 Jul 2016

@AlexRed The search field shows as explained but I think we are missing the search and clear button as seen in this field from the tags page:

screen shot 2016-07-16 at 10 01 54

I believe that should be added for consistency. Now I see this after applying the patch:
screen shot 2016-07-16 at 10 07 43

avatar roland-d roland-d - change - 16 Jul 2016
Status Ready to Commit ⇒ Information Required
Labels
avatar AlexRed
AlexRed - comment - 30 Jul 2016

It is a good idea also to set search and clear button, but I can't find it in the file. How can I edit the PR for set search and clear button ?

avatar joomla-cms-bot joomla-cms-bot - change - 30 Jul 2016
Category Components ⇒ Front End Components
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jul 2016
Labels Removed: ?
avatar roland-d
roland-d - comment - 16 Aug 2016

@AlexRed I don't know from the top of my head but you can of course check the code from the tags page and how it is done there.

avatar AlexRed
AlexRed - comment - 16 Aug 2016

sorry, but also I don't know how to do it

avatar roland-d
roland-d - comment - 16 Aug 2016

I don't have time to do it for you. Perhaps someone else can help you with that.

avatar AlexRed
AlexRed - comment - 16 Aug 2016

It is not for me, it is for all Joomla community.
But if you don't like my Pull Request to solve Issue #10901 you can close it.

avatar roland-d
roland-d - comment - 16 Aug 2016

@AlexRed I never said I don't like the PR, I actually tested it but found an inconsistency. You can't demand from me to write the code for it.

avatar AlexRed
AlexRed - comment - 18 Aug 2016

Please close. Related Pull request #11640 successfully merged.

avatar rdeutz
rdeutz - comment - 18 Aug 2016

@AlexRed you should be able to close your PR as far as I know. I hit the button for you :-)

avatar rdeutz rdeutz - change - 18 Aug 2016
Status Information Required ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-08-18 07:10:44
Closed_By ⇒ rdeutz
avatar rdeutz rdeutz - close - 18 Aug 2016

Add a Comment

Login with GitHub to post a comment