1. I like the UI now - thanks

2. You added code to com_banners but I dont see where you add a tag to a banner

3. The select box is sorted by the KEY - it should be sorted by the VALUE
   eg in english because you are sorting be KEY it displays
   Contact
   Article
   Newsfeed

There are missing strings - see this animation

I see where the banners stuff is now - its banners category

See image for the sort issue of the strings

sort issue + lang string should be ok now
@brianteeman thanks for reporting

I have tested this item ✅ successfully on e60383a

This PR has received new commits.

CC: @brianteeman

I have tested this item ✅ successfully on 9c44cbe

+COM_NEWSFEEDS_TAGS_NEWSFEED="Newsfeed"
+COM_NEWSFEEDS_TAGS_CATEGORY="Newsfeed Category"

I guess should be

+COM_NEWSFEEDS_TAGS_NEWSFEED="News Feed"
+COM_NEWSFEEDS_TAGS_CATEGORY="News Feed Category"

also concerning
$lang->load($extension . '.sys', JPATH_ADMINISTRATOR, null, false, true);

should not you add
|| $lang->load($extension . 'sys', JPath::clean(JPATH_ADMINISTRATOR . '/components/' . $extension), null, false, true);
to take into account the 3rd party extensions with language files in their language folder?

Good spot on the language strings - I missed that

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

I have tested this item ✅ successfully on 365a784

@infograf768 i've tested with com_weblinks before and later discovered
that com_weblinks lang ini files are still in the current staging (even without the component installed)
https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/en-GB.com_weblinks.sys.ini
.....

?

you can also discover com_weblinks hathor override in staging ...
https://github.com/joomla/joomla-cms/tree/staging/administrator/templates/hathor/html/com_weblinks

@alikon
com_weblinks ini files are in the global language folder (as well as smart search weblinks and search weblinks plugin files )in order to be translated by the TTs and included in their core packs.

But com_weblinks is not more a core component, so these INI should be
removed from core distribution and included in the com_weblinks repo I
think, what I'm thinking wrong?
On 24 Jun 2016 8:37 am, "infograf768" notifications@github.com wrote:

@alikon https://github.com/alikon
com_weblinks ini files are in the global language folder (as well as smart
search weblinks and search weblinks plugin files )in order to be translated
by the TTs and included in their core packs.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10895 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AALFsVYdRLpbv3FWQUXGg_Hd0o8vuJ8Cks5qO3sNgaJpZM4I7EFD
.

Ideally you are right, except that no way has been devised to get all 60+ languages ini files for the weblinks extensions to be added to the weblinks repo by the TTs in an easy way (most of them don't even know how to use git). Therefore, —until a way is defined—, any change in the various weblinks extensions en-GB ini files in their repo have to be ALSO done in core. The decision has been taken when weblinks, which is maintained by Core, was separated. And it should be the same for any other component taken away from J releases.
Not speaking about B/C, as ini files in core languages folder have priority over extensions language folder, thus would not propose the right translations or have missing new strings for people who are keeping weblinks in their 1.7=>2.5=>3.x legacy sites.

Therefore, please add the new strings in core weblinks sys ini as well as in the weblinks repo. ;)

Ok, When and if this pr will be merged, I'll submit a new pr for lang
string here and on com_weblinks + helper code ...
On 24 Jun 2016 9:00 am, "infograf768" notifications@github.com wrote:

Therefore, please add the new strings in core weblinks sys ini as well as
in the weblinks repo. ;)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10895 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AALFsSgoYl_16ZMfzg__0_sXcvLNJo1-ks5qO4CKgaJpZM4I7EFD
.

I have tested this item ? unsuccessfully on 365a784

I applied the patch. After applying tags listing now appears with the new options, no counter showing and clicking on counter circle gives me error.
Joomla version: 3.6.0

Here are the images:

Works for me

On 24 June 2016 at 13:27, hardiktasol notifications@github.com wrote:

Here are the images:
[image: screen shot 2016-06-24 at 07 26 40]
https://camo.githubusercontent.com/e00f2fd90a1a30c2a7f62a3b97f976110777245f/68747470733a2f2f6973737565732e6a6f6f6d6c612e6f72672f75706c6f6164732f312f39623739393762343933653838636334623733326134373062393437396337382e706e67
[image: screen shot 2016-06-24 at 07 26 56]

https://camo.githubusercontent.com/e72de71d4e34a382fd1e31e0c584bb776ac28047/68747470733a2f2f6973737565732e6a6f6f6d6c612e6f72672f75706c6f6164732f312f37313731353662313831663063643465366364656532393463626630366636382e706e67

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/10895
https://issues.joomla.org/tracker/joomla-cms/10895.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10895 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8X63Z3RzyrORlq8IAkuKyHtIlPEZks5qO80ygaJpZM4I7EFD
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Correction I have a found a bug

On 24 June 2016 at 13:31, Brian Teeman brian@teeman.net wrote:

Works for me

On 24 June 2016 at 13:27, hardiktasol notifications@github.com wrote:

Here are the images:
[image: screen shot 2016-06-24 at 07 26 40]
https://camo.githubusercontent.com/e00f2fd90a1a30c2a7f62a3b97f976110777245f/68747470733a2f2f6973737565732e6a6f6f6d6c612e6f72672f75706c6f6164732f312f39623739393762343933653838636334623733326134373062393437396337382e706e67
[image: screen shot 2016-06-24 at 07 26 56]

https://camo.githubusercontent.com/e72de71d4e34a382fd1e31e0c584bb776ac28047/68747470733a2f2f6973737565732e6a6f6f6d6c612e6f72672f75706c6f6164732f312f37313731353662313831663063643465366364656532393463626630366636382e706e67

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/10895
https://issues.joomla.org/tracker/joomla-cms/10895.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10895 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8X63Z3RzyrORlq8IAkuKyHtIlPEZks5qO80ygaJpZM4I7EFD
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

There is a problem when you first load the component as it shows the count even though there is no filter selected nd this is why you get a view not found. Hard to describe so I made a video

https://www.dropbox.com/s/ngcgfymxxisci1i/10895.mp4?dl=0

Exactly the problem is only with no tags selection in filter.

In my case article counter is also not visible, though there are articles with the tag added.

This PR has received new commits.

CC: @brianteeman, @hardiktasol

I have tested this item ✅ successfully on 365a784

That fixed it

I have tested this item ✅ successfully on 365a784

Now works.

RTC

Merged with e2e4b98