[#10886] - Repeated conditional expression in Url.php
- Fixed in Code Base
- 27 Aug 2016
- Medium
- Build: staging
- # 10886
- Diff
- kilida:patch-1
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
$urlScheme == 'gopher' is repeated, so it can be removed.
Testing Instructions
Semantics preserving change, no need for extra testing.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
This PR has received new commits.
CC: @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10886.
ftps and sftp and different prefixes.
@andrepereiradasilva I don't understand your comment
@brianteeman see aa4bb9c
@kilida Can you fix the issue pointed out by @andrepereiradasilva ?
This PR has received new commits.
CC: @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10886.
@kilda Shouldnt they be alpha ordered?
This PR has received new commits.
CC: @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10886.
@brianteeman In general, those lists are not alpha ordered (they start alpha ordered). With the new change it at least doesn't become less ordered.
Ok. Thanks anyway
I have tested this item
On review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10886.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10886.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-27 18:15:47 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on a100903
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10886.